Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some timeouts and reorganize tests #97115

Merged
merged 2 commits into from
Jan 20, 2024

Conversation

AaronRobinsonMSFT
Copy link
Member

Ensure target process runs to completion.
Simplify steps in test and dispose of additional classes.

Fixes #97103

Ensure target process runs to completion.
Simplify steps in test and dispose of additional classes.
@ghost
Copy link

ghost commented Jan 17, 2024

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

Issue Details

Ensure target process runs to completion.
Simplify steps in test and dispose of additional classes.

Fixes #97103

Author: AaronRobinsonMSFT
Assignees: -
Labels:

area-System.Diagnostics.Tracing

Milestone: 9.0.0

@AaronRobinsonMSFT
Copy link
Member Author

/cc @dotnet/area-system-diagnostics-coreclr

@AaronRobinsonMSFT
Copy link
Member Author

@dotnet/dotnet-diag

Copy link
Member

@davmason davmason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit ca1b161 into dotnet:main Jan 20, 2024
108 of 111 checks passed
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the runtime_97103 branch January 20, 2024 00:29
@AaronRobinsonMSFT
Copy link
Member Author

Wasm failures are unrelated.

tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
Ensure target process runs to completion.
Simplify steps in test and dispose of additional classes.
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BasicEventSourceTests.TestsManifestGeneration test failing in CI
2 participants