Use DivRem in Decimal.DecCalc #97619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-numerics Issue DetailsUse There are also many 64 by 32 (32-bit remainder with some using 64-bit quotient and some truncating to 64-bit quotient). Wasn't sure if we want to put those in some internal method, thoughts?
|
This was referenced Jan 28, 2024
|
I remember some ones can be better simplified with X86Base.DivRem, which is still not implemented in Mono yet. |
tannergooding
approved these changes
Jan 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
Math.DivRem(uint, uint)andMath.DivRem(ulong, ulong)indecimal.There are also many 64 by 32 (32-bit remainder with some using 64-bit quotient and some truncating to 64-bit quotient). Wasn't sure if we want to put those in some internal method, thoughts?