Add Sve.IsSupported support #97814

a74nh · 2024-02-01T14:31:17Z

Add the SVE API, but it only includes the IsSupported method.

Add the blank test files to go along with it

dotnet-issue-labeler · 2024-02-01T14:31:25Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost · 2024-02-01T14:31:30Z

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

Issue Details

Add the SVE API, but it only includes the IsSupported method.

Add the blank test files to go along with it

Author:	a74nh
Assignees:	-
Labels:	`area-System.Runtime.Intrinsics`, `new-api-needs-documentation`, `community-contribution`
Milestone:	-

a74nh · 2024-02-01T14:38:07Z

This is cut from #97695

I'm still a little confused about the testing. I can get the .cs files to generate. But then I'm not sure how to build and run the generated test files.

Also, what do I need to build+run to get PrintSupportedIsa() (in Shared/Program.cs) to print?

For now, the new SVE block inside GenerateHWIntrinsicTests_Arm.cs just contains a duplication of the existing LoadUnOpTest.template, which can be removed as soon as the first Sve API entry is added.

@kunalspathak @dotnet/arm64-contrib @tannergooding

tannergooding · 2024-02-01T15:26:10Z

The general process for tests is going to be:

Add the new table entries to https:/dotnet/runtime/blob/main/src/tests/Common/GenerateHWIntrinsicTests/GenerateHWIntrinsicTests_Arm.cs
Add an Sve folder to https:/dotnet/runtime/tree/main/src/tests/JIT/HardwareIntrinsics/Arm which follows the general setup of https:/dotnet/runtime/tree/main/src/tests/JIT/HardwareIntrinsics/Arm/AdvSimd (Sve_r.csproj, Sve_ro.csproj, Program.Sve.cs)
Build and run the tests according to https:/dotnet/runtime/blob/main/docs/workflow/testing/coreclr/testing.md

ryujit-bot · 2024-02-01T16:50:40Z

Diff results for #97814

Throughput diffs

Throughput diffs for windows/arm64 ran on windows/x64

MinOpts (-0.01% to +0.00%)

Collection	PDIFF
libraries.pmi.windows.arm64.checked.mch	-0.01%

Details here

kunalspathak

@tannergooding - are there other places where we should set the bits for IsSupported or this should be good enough?

src/tests/Common/GenerateHWIntrinsicTests/GenerateHWIntrinsicTests_Arm.cs

src/coreclr/jit/hwintrinsiclistarm64sve.h

ryujit-bot · 2024-02-02T13:52:43Z

Diff results for #97814

Throughput diffs

Throughput diffs for linux/arm64 ran on windows/x64

MinOpts (-0.01% to +0.00%)

Collection	PDIFF
libraries.pmi.linux.arm64.checked.mch	-0.01%

Throughput diffs for windows/arm64 ran on windows/x64

MinOpts (-0.00% to +0.01%)

Collection	PDIFF
libraries.pmi.windows.arm64.checked.mch	+0.01%

Details here

a74nh · 2024-02-02T14:31:06Z

Test results on SVE enabled machine running HardwareIntrinsics_Arm_r.sh:

14:29:58.994 Running test: JIT/HardwareIntrinsics/Arm/Sve/Sve_r/Sve_r.dll
Supported ISAs:
  AdvSimd:   True
  Aes:       True
  ArmBase:   True
  Crc32:     True
  Dp:        True
  Rdm:       True
  Sha1:      True
  Sha256:    True
  Sve:       True

Beginning scenario: RunBasicScenario_Load
Beginning scenario: RunReflectionScenario_Load
14:29:59.005 Passed test: JIT/HardwareIntrinsics/Arm/Sve/Sve_r/Sve_r.dll

a74nh · 2024-02-05T09:16:35Z

2024-02-02T12:15:09.0048116Z ##[error].packages/microsoft.dotnet.apicompat.task/9.0.100-alpha.1.24072.3/build/Microsoft.DotNet.ApiCompat.ValidateAssemblies.Common.targets(16,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) API breaking changes found. If those are intentional, the APICompat suppression file can be updated by rebuilding with '/p:ApiCompatGenerateSuppressionFile=true'

I'm not sure how to fix this in the PR.

kunalspathak · 2024-02-05T18:09:55Z

I'm not sure how to fix this in the PR.

there were few missing places. my changes should fix it.

ryujit-bot · 2024-02-05T20:02:47Z

Diff results for #97814

Throughput diffs

Throughput diffs for linux/arm64 ran on windows/x64

MinOpts (-0.00% to +0.01%)

Collection	PDIFF
libraries.pmi.linux.arm64.checked.mch	+0.01%

Details here

kunalspathak · 2024-02-05T20:58:48Z

Test results on SVE enabled machine running HardwareIntrinsics_Arm_r.sh:

14:29:58.994 Running test: JIT/HardwareIntrinsics/Arm/Sve/Sve_r/Sve_r.dll
Supported ISAs:
  AdvSimd:   True
  Aes:       True
  ArmBase:   True
  Crc32:     True
  Dp:        True
  Rdm:       True
  Sha1:      True
  Sha256:    True
  Sve:       True

Beginning scenario: RunBasicScenario_Load
Beginning scenario: RunReflectionScenario_Load
14:29:59.005 Passed test: JIT/HardwareIntrinsics/Arm/Sve/Sve_r/Sve_r.dll

@fanyang-mono - how can we verify if this returns false for Mono?

fanyang-mono · 2024-02-05T22:25:17Z

@kunalspathak The change I suggested here is needed, in order for Mono to return false for IsSupported check.

Once this change is in place, you could build mono and write a small program to call IsSupported on Sve to check the value. Note that the CI lane to exercise runtime tests on arm64 is currently disable. Otherwise, we could check CI log as well.

kunalspathak

LGTM. Thanks!

ryujit-bot · 2024-02-06T15:06:07Z

Diff results for #97814

Throughput diffs

Throughput diffs for linux/arm64 ran on windows/x64

MinOpts (-0.01% to +0.00%)

Collection	PDIFF
libraries.pmi.linux.arm64.checked.mch	-0.01%

Details here

...braries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve.PlatformNotSupported.cs

src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve.cs

src/tests/Common/GenerateHWIntrinsicTests/GenerateHWIntrinsicTests_Arm.cs

tannergooding

The changes in general LGTM, but the Sve.PlatformNotSupported.cs file in particular needs to follow the correct pattern.

...braries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve.PlatformNotSupported.cs

ryujit-bot · 2024-02-07T17:09:31Z

Diff results for #97814

Throughput diffs

Throughput diffs for linux/arm64 ran on windows/x64

MinOpts (-0.01% to +0.00%)

Collection	PDIFF
libraries.pmi.linux.arm64.checked.mch	-0.01%

Throughput diffs for windows/arm64 ran on windows/x64

MinOpts (-0.00% to +0.01%)

Collection	PDIFF
libraries.pmi.windows.arm64.checked.mch	+0.01%

Details here

ryujit-bot · 2024-02-07T18:09:46Z

Diff results for #97814

Throughput diffs

Throughput diffs for windows/arm64 ran on linux/x64

MinOpts (-0.01% to +0.00%)

Collection	PDIFF
libraries.pmi.windows.arm64.checked.mch	-0.01%

Details here

ryujit-bot · 2024-02-07T19:09:59Z

Diff results for #97814

Throughput diffs

Throughput diffs for windows/arm64 ran on windows/x64

MinOpts (-0.01% to +0.00%)

Collection	PDIFF
libraries.pmi.windows.arm64.checked.mch	-0.01%

Details here

kunalspathak · 2024-02-07T21:09:04Z

All failures are known:

kunalspathak · 2024-02-13T06:53:42Z

Test results on SVE enabled machine running HardwareIntrinsics_Arm_r.sh:

14:29:58.994 Running test: JIT/HardwareIntrinsics/Arm/Sve/Sve_r/Sve_r.dll
Supported ISAs:
  AdvSimd:   True
  Aes:       True
  ArmBase:   True
  Crc32:     True
  Dp:        True
  Rdm:       True
  Sha1:      True
  Sha256:    True
  Sve:       True

Beginning scenario: RunBasicScenario_Load
Beginning scenario: RunReflectionScenario_Load
14:29:59.005 Passed test: JIT/HardwareIntrinsics/Arm/Sve/Sve_r/Sve_r.dll

It just occurred to me that this should return false on windows/arm64 SVE machine until windows support is not added.

tannergooding · 2024-02-13T17:35:41Z

It just occurred to me that this should return false on windows/arm64 SVE machine until windows support is not added.

Shouldn't that already fall out from the VM support?

tannergooding · 2024-02-13T17:38:02Z

We set it for Unix here: https:/dotnet/runtime/blob/main/src/native/minipal/cpufeatures.c#L362-L363

and never set it for Windows, as no way to check the API exists yet:
https:/dotnet/runtime/blob/main/src/native/minipal/cpufeatures.c#L406-L439

kunalspathak · 2024-02-13T18:11:08Z

We set it for Unix here: https:/dotnet/runtime/blob/main/src/native/minipal/cpufeatures.c#L362-L363

and never set it for Windows, as no way to check the API exists yet: https:/dotnet/runtime/blob/main/src/native/minipal/cpufeatures.c#L406-L439

perfect. Thanks for confirming.

Add Sve.IsSupported support

cf31dd8

ghost added the community-contribution Indicates that the PR has been added by a community member label Feb 1, 2024

dotnet-issue-labeler bot added area-System.Runtime.Intrinsics new-api-needs-documentation labels Feb 1, 2024

a74nh marked this pull request as ready for review February 1, 2024 14:38

This was referenced Feb 1, 2024

Checkout failure: "Git fetch failed with exit code 128" dotnet/arcade#9009

Open

"We stopped hearing from agent Azure Pipelines 32. Verify the agent machine is running and has a healthy network connection" dotnet/dnceng#1886

Open

kunalspathak added the arm-sve Work related to arm64 SVE/SVE2 support label Feb 1, 2024

kunalspathak reviewed Feb 1, 2024

View reviewed changes

src/tests/Common/GenerateHWIntrinsicTests/GenerateHWIntrinsicTests_Arm.cs Outdated Show resolved Hide resolved

src/tests/Common/GenerateHWIntrinsicTests/GenerateHWIntrinsicTests_Arm.cs Show resolved Hide resolved

src/coreclr/jit/hwintrinsiclistarm64sve.h Show resolved Hide resolved

build-analysis bot mentioned this pull request Feb 1, 2024

slow macOS - "##[error]The job running on agent Azure Pipelines 9 ran longer than the maximum time of 60 minutes." dotnet/dnceng#1883

Open

3 tasks

Remove debugging

6f1633c

kunalspathak added 2 commits February 5, 2024 08:29

Add RequiresPreviewFeaturesAttribute in PlatformNotSupported file

f4c6bf7

fix the base class name

fe0c6c6

This was referenced Feb 5, 2024

NuGet failing with Response status code does not indicate success: 503 (Service Unavailable) dotnet/arcade#11723

Open

Tests crashing in CI with no dump: exit code 137 means SIGKILL Killed #97049

Closed

Add mono checks

15cd4a5

a74nh requested review from fanyang-mono and vargaz as code owners February 6, 2024 12:16

kunalspathak approved these changes Feb 6, 2024

View reviewed changes

build-analysis bot mentioned this pull request Feb 6, 2024

[mono][tvos] OOM in System.IO.Tests.MemoryStreamTests #92467

Closed

tannergooding reviewed Feb 6, 2024

View reviewed changes

...braries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve.PlatformNotSupported.cs Outdated Show resolved Hide resolved

tannergooding reviewed Feb 6, 2024

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve.cs Outdated Show resolved Hide resolved

tannergooding reviewed Feb 6, 2024

View reviewed changes

src/tests/Common/GenerateHWIntrinsicTests/GenerateHWIntrinsicTests_Arm.cs Show resolved Hide resolved

tannergooding requested changes Feb 6, 2024

View reviewed changes

ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Feb 6, 2024

Review cleanups

f8dee50

ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Feb 7, 2024

Remove dummy sve test

62f3a58

kunalspathak reviewed Feb 7, 2024

View reviewed changes

...braries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve.PlatformNotSupported.cs Show resolved Hide resolved

Fix Sve.PlatformNotSupported.cs

92f736a

tannergooding reviewed Feb 7, 2024

View reviewed changes

...braries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve.PlatformNotSupported.cs Outdated Show resolved Hide resolved

Remove intrinsic marking

25532ae

tannergooding approved these changes Feb 7, 2024

View reviewed changes

kunalspathak merged commit b449152 into dotnet:main Feb 7, 2024
202 of 208 checks passed

github-actions bot locked and limited conversation to collaborators Mar 16, 2024

Add Sve.IsSupported support #97814

Add Sve.IsSupported support #97814

Conversation

a74nh commented Feb 1, 2024

dotnet-issue-labeler bot commented Feb 1, 2024

ghost commented Feb 1, 2024

a74nh commented Feb 1, 2024

tannergooding commented Feb 1, 2024

ryujit-bot commented Feb 1, 2024

Throughput diffs

Throughput diffs for windows/arm64 ran on windows/x64

kunalspathak left a comment

Choose a reason for hiding this comment

ryujit-bot commented Feb 2, 2024

Throughput diffs

Throughput diffs for linux/arm64 ran on windows/x64

Throughput diffs for windows/arm64 ran on windows/x64

a74nh commented Feb 2, 2024

a74nh commented Feb 5, 2024

kunalspathak commented Feb 5, 2024

ryujit-bot commented Feb 5, 2024

Throughput diffs

Throughput diffs for linux/arm64 ran on windows/x64

kunalspathak commented Feb 5, 2024

fanyang-mono commented Feb 5, 2024 • edited Loading

kunalspathak left a comment

Choose a reason for hiding this comment

ryujit-bot commented Feb 6, 2024

Throughput diffs

Throughput diffs for linux/arm64 ran on windows/x64

tannergooding left a comment

Choose a reason for hiding this comment

ryujit-bot commented Feb 7, 2024

Throughput diffs

Throughput diffs for linux/arm64 ran on windows/x64

Throughput diffs for windows/arm64 ran on windows/x64

ryujit-bot commented Feb 7, 2024

Throughput diffs

Throughput diffs for windows/arm64 ran on linux/x64

ryujit-bot commented Feb 7, 2024

Throughput diffs

Throughput diffs for windows/arm64 ran on windows/x64

kunalspathak commented Feb 7, 2024

kunalspathak commented Feb 13, 2024

tannergooding commented Feb 13, 2024

tannergooding commented Feb 13, 2024

kunalspathak commented Feb 13, 2024

fanyang-mono commented Feb 5, 2024 •

edited

Loading