Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intrinsify typeof(T).IsGenericType #99555

Merged
merged 21 commits into from
Jun 16, 2024
Merged

Intrinsify typeof(T).IsGenericType #99555

merged 21 commits into from
Jun 16, 2024

Commits on Jun 16, 2024

  1. Make Type.IsGenericType a JIT intrinsic

    @Sergio0694
    Sergio0694 committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    ac5218a View commit details
    Browse the repository at this point in the history

  2. Add Type.IsGenericType intrinsic tests

    @Sergio0694
    Sergio0694 committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    c9d6555 View commit details
    Browse the repository at this point in the history

  3. Add intrinsic tests for nested types too

    @Sergio0694
    Sergio0694 committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    c74d7ab View commit details
    Browse the repository at this point in the history

  4. Skip expanding the intrinsic for __Canon

    @Sergio0694
    Sergio0694 committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    7e9f1bb View commit details
    Browse the repository at this point in the history

  5. Add 'isGenericType' generated thunk 

    Fix vtable in CorInfoImpl_generated.cs
    @Sergio0694
    Sergio0694 committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    87438ea View commit details
    Browse the repository at this point in the history

  6. Implement 'isGenericType' JIT/EE method

    @Sergio0694
    Sergio0694 committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    1f42a91 View commit details
    Browse the repository at this point in the history

  7. Plug 'isGenericType' in importer

    @Sergio0694
    Sergio0694 committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    33c4b6f View commit details
    Browse the repository at this point in the history

  8. Fix superPMI build

    @Sergio0694
    Sergio0694 committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    de41e53 View commit details
    Browse the repository at this point in the history

  9. Use 'TypeCompareState' for 'isGenericType'

    @Sergio0694
    Sergio0694 committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    3b3d31d View commit details
    Browse the repository at this point in the history

  10. Add more test cases for shared generics

    @Sergio0694
    Sergio0694 committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    fd9a450 View commit details
    Browse the repository at this point in the history

  11. Remove ref struct type from 'IsGenericType' tests

    @Sergio0694
    Sergio0694 committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    b5cc4eb View commit details
    Browse the repository at this point in the history

  12. Make __Canon type check less conservative 

    Co-authored-by: Jan Kotas <[email protected]>
    @Sergio0694 @jkotas
    Sergio0694 and jkotas committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    33c2fbf View commit details
    Browse the repository at this point in the history

  13. Update __Canon check in managed impl too 

    Co-authored-by: Michal Strehovský <[email protected]>
    @Sergio0694 @MichalStrehovsky
    Sergio0694 and MichalStrehovsky committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    affbcd1 View commit details
    Browse the repository at this point in the history

  14. Update tests, make them no inline

    @Sergio0694
    Sergio0694 committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    8692331 View commit details
    Browse the repository at this point in the history

  15. Update generated code

    @Sergio0694
    Sergio0694 committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    42a59db View commit details
    Browse the repository at this point in the history

  16. Fix rebase errors

    @MihaZupan @Sergio0694
    MihaZupan authored and Sergio0694 committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    140e261 View commit details
    Browse the repository at this point in the history

  17. Fix more rebase errors

    @Sergio0694
    Sergio0694 committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    b0c8c75 View commit details
    Browse the repository at this point in the history

  18. Update jitinterface.cpp

    @EgorBo
    EgorBo authored Jun 16, 2024
    Configuration menu
    Copy the full SHA
    791e29e View commit details
    Browse the repository at this point in the history

  19. Make isGenericType use _LEAF transition 

    Co-authored-by: Jan Kotas <[email protected]>
    @Sergio0694 @jkotas
    Sergio0694 and jkotas authored Jun 16, 2024
    Configuration menu
    Copy the full SHA
    09e55a2 View commit details
    Browse the repository at this point in the history

  20. Make isNullableType use _LEAF transition

    @Sergio0694
    Sergio0694 committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    1a7b1c1 View commit details
    Browse the repository at this point in the history

  21. Remove unnecessary shared generic check

    @Sergio0694
    Sergio0694 committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    75967c2 View commit details
    Browse the repository at this point in the history