Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit all uses of ExecutableWriterHolder and ExecutableWriterHolderNo… #2719

Open
wants to merge 1 commit into
base: feature/CoreclrInterpreter
Choose a base branch
from

Conversation

AaronRobinsonMSFT
Copy link
Member

…Log under src\coreclr.

/cc @janvorli @cshung


`CommitPages()`
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generates pages of code with many instances of SubPrecode, FixupPrecode and CallCountingStub. This block of pages is interleaved with the same sized block of RW pages containing data that the generated stubs use. The m_codePageGenerator is a function that generates the stub code.

`src\coreclr\vm\amd64\jitinterfaceamd64.cpp`:
## `src\coreclr\vm\amd64\jitinterfaceamd64.cpp`:

`WriteBarrierManager::ChangeWriteBarrierTo` - Alter the `JIT_WriteBarrier`?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it changes the write barrier code to a different version (depending on the GC mode etc)


`UnlockedLoaderHeap::UnlockedBackoutMem` - back out allocation?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This frees memory allocated by the last AllocMem. It is used only to backout in error situations to prevent memory leaks, this kind of heap doesn't allow regular memory freeing.

`src\coreclr\vm\precode.cpp`:
## `src\coreclr\vm\precode.cpp`:

`Precode::Allocate` - Only for `PRECODE_THISPTR_RETBUF`.
Copy link
Member

@janvorli janvorli Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be used for more - call counting stub, func ptr stubs Sorry, I take this back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants