Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using SDK compiler in torn builds #41791

Closed
10 tasks
jaredpar opened this issue Jun 25, 2024 · 1 comment · Fixed by #41951
Closed
10 tasks

Using SDK compiler in torn builds #41791

jaredpar opened this issue Jun 25, 2024 · 1 comment · Fixed by #41951
Assignees
Labels
Area-NetSDK untriaged Request triage from a team member
Milestone

Comments

@jaredpar
Copy link
Member

jaredpar commented Jun 25, 2024

This is the work breakdown for #41790.

  • Flow the Micosoft.Net.Compilers.Toolset.Framework package to the .NET SDK
  • Create a new package Micosoft.Microsoft.Net.Sdk.Compilers.Toolset in .NET SDK.
    • The contents of this package will include the contents of the tasks\net472 folder in the Microsoft.Net.Compilers.Toolset.Framework package. This subset is all that is needed and makes the package not usable via <PackageReference>. The latter reduces the incentive for customers to use it directly.
    • The contents will include a README.md stating the package is not supported for direct user consumption.
    • The package will follow the versioning scheme of the .NET SDK.
    • The package will be unlisted (ideal but not a hard requirement)
  • Change the Sdk.targets file to have copies of the following three <UsingTasks> from [Microsoft.Common.tasks][microsoft-common-tasks]. Having a copy in Sdk.targets means that resetting $(RoslynTargetsPath) during build will change the chosen compiler.
  • When the .NET SDK detects a torn state
    • Use a <PackageDownload> to acquire the Microsoft.Net.Sdk.Compilers.Toolset package
    • Change $(RoslynTargetsPath) to point into the package contents
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-NuGet untriaged Request triage from a team member labels Jun 25, 2024
@jaredpar jaredpar added this to the 9.0.1xx milestone Jun 25, 2024
Copy link
Contributor

Thanks for creating this issue! We believe this issue is related to NuGet tooling, which is maintained by the NuGet team. Thus, we closed this one and encourage you to raise this issue in the NuGet repository instead. Don’t forget to check out NuGet’s contributing guide before submitting an issue!

If you believe this issue was closed out of error, please comment to let us know.

Happy Coding!

@dotnet-policy-service dotnet-policy-service bot removed this from the 9.0.1xx milestone Jun 25, 2024
@baronfel baronfel reopened this Jun 25, 2024
@baronfel baronfel added this to the 9.0.1xx milestone Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-NetSDK untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants