Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface addtextextension setting in TemplateVerifierOptions #5785

Open
Tracked by #5705
JanKrivanek opened this issue Dec 19, 2022 · 1 comment
Open
Tracked by #5705

Surface addtextextension setting in TemplateVerifierOptions #5785

JanKrivanek opened this issue Dec 19, 2022 · 1 comment
Labels
area: authoring tools Related to authoring tools good first issue easy issue, good for first-time contribution to the repo Priority:3 Work that is nice to have triaged The issue was evaluated by the triage team, placed on correct area, next action defined.
Milestone

Comments

@JanKrivanek
Copy link
Member

JanKrivanek commented Dec 19, 2022

Is your feature request related to a problem? Please describe.

TemplateVerifier performs binary stream comparison of files with unrecognized or no extensions. Textual comparison is preferable in cases where content is text (due to normalization of newlines, byte order marks, etc.)

Describe the solution you'd like.

There is an option in Verify to tag file extension as textual: https:/VerifyTests/EmptyFiles#addtextextension, the content verification then will work as on text (same as for well recognized textual extensions)

This should be surfaced via TemplateVerifierOptions (e.g. as AdditionalTextExtensions) and then passed to Verify.

Additionally the special case noextension extension should be allways implicitly added

@JanKrivanek JanKrivanek added the good first issue easy issue, good for first-time contribution to the repo label Dec 19, 2022
@vlada-shubina vlada-shubina added the triaged The issue was evaluated by the triage team, placed on correct area, next action defined. label Dec 19, 2022
@vlada-shubina vlada-shubina added this to the Backlog milestone Dec 19, 2022
@JanKrivanek
Copy link
Member Author

More involved and 'unattended' solution might be to check if the extension is reconginzed as textual, if not attempt to autodetect the format of the file (more on that e.g. here: #5789 (comment)) and then call the AddExtension automatically if needed.

@vlada-shubina vlada-shubina added the area: authoring tools Related to authoring tools label Mar 1, 2023
@YuliiaKovalova YuliiaKovalova added the Priority:3 Work that is nice to have label May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: authoring tools Related to authoring tools good first issue easy issue, good for first-time contribution to the repo Priority:3 Work that is nice to have triaged The issue was evaluated by the triage team, placed on correct area, next action defined.
Projects
None yet
Development

No branches or pull requests

3 participants