incremented precedence for project templates #4299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlada-shubina
added
the
servicing-consider
|
Just curious, but could the precedence be generated based on the .NET major/minor version, that way when we rebrand for a new release, this change won't be necessary in the future? |
DavidKarlas
approved these changes
Jan 25, 2022
DavidKarlas
approved these changes
Jan 25, 2022
donJoseLuis
approved these changes
Jan 25, 2022
In theory, this is possible however precedence is integer value, so it needs a bit of math and also an approach on how to update json files automatically. We are looking to introducing MSBuild tasks for validation at the build time, that will allow to catch these errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4295 to release/7.0.1xx-preview1
Issue:
#4296
Description:
#4296 discovered that that templates from .NET 6 SDK and .NET 7 SDK conflicts due to unchanged precedence. PR increases the precedence for .NET 7 templates.
Customer impact:
unable to use console / classlib templates when both .NET 6 SDK and .NET 7 SDK is installed.
Regression:
yes
Risk:
Low. Tested manually and with automation tests.