Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TemplateVerifier docs #5510

Merged
merged 2 commits into from
Nov 1, 2022
Merged

TemplateVerifier docs #5510

merged 2 commits into from
Nov 1, 2022

Conversation

JanKrivanek
Copy link
Member

@JanKrivanek JanKrivanek commented Oct 26, 2022

Solution

Doc content for the TemplateVerifier feature #3868

Checks: N/A

  • Added unit tests
  • Added #nullable enable to all the modified files ?

@JanKrivanek JanKrivanek added the do-not-merge The PR should not be merged until impediments are resolved. label Oct 26, 2022
@JanKrivanek JanKrivanek marked this pull request as ready for review October 26, 2022 16:48
@JanKrivanek JanKrivanek requested review from a team and baronfel as code owners October 26, 2022 16:48
@JanKrivanek JanKrivanek changed the title [WIP] TemplateVerifier docs TemplateVerifier docs Oct 26, 2022
@JanKrivanek JanKrivanek removed the do-not-merge The PR should not be merged until impediments are resolved. label Oct 26, 2022
Copy link
Member

@vlada-shubina vlada-shubina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Probably we can also kick off the folder for authoring tooling, and also move localization article there.

TemplateSpecificArgs = new[] { "--arg1", "true" },
};

VerificationEngine engine = new(_logger);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be good to have an overload from XUnit logging too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently the API is intentionaly agnostic on the testing frameworks (under the hood it uses Verify.Xunit, but just because the Verify functionality is currently surfaced only through 'protocol specific packages', however XUnit is neither enforced nor surfaced anywhere).

E.g. this specific code sample is in MSTest

docs/Templates-Testing-Tooling.md Outdated Show resolved Hide resolved
docs/Templates-Testing-Tooling.md Outdated Show resolved Hide resolved
@JanKrivanek JanKrivanek enabled auto-merge (squash) November 1, 2022 07:53
@JanKrivanek JanKrivanek merged commit 654f4b5 into dotnet:main Nov 1, 2022
@JanKrivanek JanKrivanek deleted the verify-docs branch November 1, 2022 09:37
@JanKrivanek JanKrivanek mentioned this pull request Nov 1, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants