Cover TemplateSamples with tests #5794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanKrivanek
requested changes
Dec 20, 2022
...soft.TemplateEngine.Authoring.TemplateVerifier.IntegrationTests/TemplateEngineSamplesTest.cs
Outdated
Show resolved
Hide resolved
...soft.TemplateEngine.Authoring.TemplateVerifier.IntegrationTests/TemplateEngineSamplesTest.cs
Show resolved
Hide resolved
...soft.TemplateEngine.Authoring.TemplateVerifier.IntegrationTests/TemplateEngineSamplesTest.cs
Outdated
Show resolved
Hide resolved
...soft.TemplateEngine.Authoring.TemplateVerifier.IntegrationTests/TemplateEngineSamplesTest.cs
Outdated
Show resolved
Hide resolved
…ub.com/YuliiaKovalova/templating_change_conditional_sntx into dev/ykovalova/cover_samples_with_tests
vlada-shubina
requested changes
Dec 20, 2022
...IntegrationTests/Microsoft.TemplateEngine.Authoring.TemplateVerifier.IntegrationTests.csproj
Outdated
Show resolved
Hide resolved
...soft.TemplateEngine.Authoring.TemplateVerifier.IntegrationTests/TemplateEngineSamplesTest.cs
Outdated
Show resolved
Hide resolved
...soft.TemplateEngine.Authoring.TemplateVerifier.IntegrationTests/TemplateEngineSamplesTest.cs
Outdated
Show resolved
Hide resolved
...soft.TemplateEngine.Authoring.TemplateVerifier.IntegrationTests/TemplateEngineSamplesTest.cs
Outdated
Show resolved
Hide resolved
...soft.TemplateEngine.Authoring.TemplateVerifier.IntegrationTests/TemplateEngineSamplesTest.cs
Show resolved
Hide resolved
...tionTests/Snapshots/TemplateEngineSamplesProjectTest.sample02._.verified/sample02/Program.cs
Outdated
Show resolved
Hide resolved
...soft.TemplateEngine.Authoring.TemplateVerifier.IntegrationTests/TemplateEngineSamplesTest.cs
Outdated
Show resolved
Hide resolved
11 tasks
|
I have addressed all your comments. Please take a look |
vlada-shubina
approved these changes
Dec 21, 2022
...soft.TemplateEngine.Authoring.TemplateVerifier.IntegrationTests/TemplateEngineSamplesTest.cs
Outdated
Show resolved
Hide resolved
...soft.TemplateEngine.Authoring.TemplateVerifier.IntegrationTests/TemplateEngineSamplesTest.cs
Outdated
Show resolved
Hide resolved
...soft.TemplateEngine.Authoring.TemplateVerifier.IntegrationTests/TemplateEngineSamplesTest.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Vlada Shubina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2522 (comment)