MSBuild ValidateTemplates task PoC
#5840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuliiaKovalova
approved these changes
Jan 17, 2023
|
Looks good! |
JanKrivanek
approved these changes
Feb 24, 2023
tools/Microsoft.TemplateEngine.Authoring.Tasks/Tasks/ValidateTemplates.cs
Outdated
Show resolved
Hide resolved
tools/Microsoft.TemplateEngine.Authoring.Tasks/Tasks/ValidateTemplates.cs
Show resolved
Hide resolved
tools/Microsoft.TemplateEngine.Authoring.Tasks/Tasks/ValidateTemplates.cs
Outdated
Show resolved
Hide resolved
tools/Microsoft.TemplateEngine.Authoring.Tasks/Tasks/ValidateTemplates.cs
Outdated
Show resolved
Hide resolved
vlada-shubina
changed the base branch from
dev/vshubina/validation-poc
to
feature/validation
vlada-shubina
force-pushed
the
validation-MSBuild-task
branch
from
398ac6f
to
ec25b81
Compare
vlada-shubina
force-pushed
the
validation-MSBuild-task
branch
from
ec25b81
to
9b89493
Compare
vlada-shubina
added a commit
that referenced
this pull request
Mar 15, 2023
* MSBuild validate task PoC * review comments * localization
vlada-shubina
added a commit
that referenced
this pull request
Mar 17, 2023
* MSBuild validate task PoC * review comments * localization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Template validation
Solution
follow up for #5838
usage of new validation from MSBuild authoring tasks
TODO:
Checks:
#nullable enableto all the modified files ?