-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Coverage for ClipboardProxy from PR #11863 #12227
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12227 +/- ##
===================================================
+ Coverage 75.55840% 75.56431% +0.00591%
===================================================
Files 3111 3112 +1
Lines 635122 635157 +35
Branches 46914 46917 +3
===================================================
+ Hits 479888 479952 +64
+ Misses 151775 151751 -24
+ Partials 3459 3454 -5
Flags with carried forward coverage won't be shown. Click here to find out more. |
src/Microsoft.VisualBasic.Forms/tests/UnitTests/System/Windows/Forms/ClipboardProxyTests.vb
Show resolved
Hide resolved
@Tanya-Solyanik based on all the work you are doing on Clipboard should I close this? If there are still uncover ClipboardProxy areas I can open a new PR after it's merged. |
@Tanya-Solyanik
If you have these covered or don't think they need to be I will close. |
Namespace Microsoft.VisualBasic.Forms.Tests | ||
|
||
''' <summary> | ||
''' These are just checking the Proxy functions, the underlying functions are tested elsewhere. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
''' These are just checking the Proxy functions, the underlying functions are tested elsewhere. | |
''' These are just checking the <see cref="ClipboardProxy" /> functions, the underlying functions are tested elsewhere. |
src/Microsoft.VisualBasic.Forms/tests/UnitTests/System/Windows/Forms/ClipboardProxyTests.vb
Outdated
Show resolved
Hide resolved
Public Class ClipboardProxyTests | ||
|
||
<WinFormsFact> | ||
Public Sub ClipboardProxy_ContainsText() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is equivalent to
Line 84 in 3760721
public void Text() |
src/Microsoft.VisualBasic.Forms/tests/UnitTests/System/Windows/Forms/ClipboardProxyTests.vb
Outdated
Show resolved
Hide resolved
src/Microsoft.VisualBasic.Forms/tests/UnitTests/System/Windows/Forms/ClipboardProxyTests.vb
Show resolved
Hide resolved
src/Microsoft.VisualBasic.Forms/tests/UnitTests/System/Windows/Forms/ClipboardProxyTests.vb
Outdated
Show resolved
Hide resolved
src/Microsoft.VisualBasic.Forms/tests/UnitTests/System/Windows/Forms/ClipboardProxyTests.vb
Outdated
Show resolved
Hide resolved
These are covered as exposed from the Clipboard class, we still need tests on the Proxy level that establish that it invokes the CLipboard methods or at least gets the same results as the Clipboard does. |
Fixes #
Proposed changes
Customer Impact
Regression?
Risk
Microsoft Reviewers: Open in CodeFlow