Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Coverage for ClipboardProxy from PR #11863 #12227

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

paul1956
Copy link
Contributor

@paul1956 paul1956 commented Sep 26, 2024

Fixes #

Proposed changes

Customer Impact

  • Improved code quality

Regression?

  • No

Risk

  • None add additional tests
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.56431%. Comparing base (0469577) to head (946f18e).

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12227         +/-   ##
===================================================
+ Coverage   75.55840%   75.56431%   +0.00591%     
===================================================
  Files           3111        3112          +1     
  Lines         635122      635157         +35     
  Branches       46914       46917          +3     
===================================================
+ Hits          479888      479952         +64     
+ Misses        151775      151751         -24     
+ Partials        3459        3454          -5     
Flag Coverage Δ
Debug 75.56431% <100.00000%> (+0.00591%) ⬆️
integration 18.29755% <ø> (+0.01411%) ⬆️
production 49.04142% <ø> (+0.01020%) ⬆️
test 97.03109% <100.00000%> (+0.00030%) ⬆️
unit 45.97334% <ø> (-0.01654%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@paul1956 paul1956 changed the title Add Clipboard Proxy Tests from PR #11863 Add code coverage to ClipboardProxy from PR #11863 Sep 27, 2024
@paul1956 paul1956 changed the title Add code coverage to ClipboardProxy from PR #11863 Adds code coverage to ClipboardProxy from PR #11863 Sep 28, 2024
@Tanya-Solyanik Tanya-Solyanik added the 📭 waiting-author-feedback The team requires more information from the author label Sep 30, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Sep 30, 2024
@paul1956
Copy link
Contributor Author

paul1956 commented Oct 10, 2024

@Tanya-Solyanik based on all the work you are doing on Clipboard should I close this? If there are still uncover ClipboardProxy areas I can open a new PR after it's merged.

@paul1956
Copy link
Contributor Author

@Tanya-Solyanik
The following ClipboardProxy functions are currently missing coverage and the ones I was testing with this PR.

Friend Sub New()
Public Function GetAudioStream() As Stream
Public Function ContainsText(format As TextDataFormat) As Boolean
Public Function GetAudioStream() As Stream
Public Function GetFileDropList() As StringCollection
Public Sub SetAudio(audioBytes As Byte())
Public Sub SetFileDropList(filePaths As StringCollection)

If you have these covered or don't think they need to be I will close.

Namespace Microsoft.VisualBasic.Forms.Tests

''' <summary>
''' These are just checking the Proxy functions, the underlying functions are tested elsewhere.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
''' These are just checking the Proxy functions, the underlying functions are tested elsewhere.
''' These are just checking the <see cref="ClipboardProxy" /> functions, the underlying functions are tested elsewhere.

Public Class ClipboardProxyTests

<WinFormsFact>
Public Sub ClipboardProxy_ContainsText()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tanya-Solyanik Tanya-Solyanik added the 📭 waiting-author-feedback The team requires more information from the author label Oct 11, 2024
@Tanya-Solyanik
Copy link
Member

If you have these covered or don't think they need to be I will close.

These are covered as exposed from the Clipboard class, we still need tests on the Proxy level that establish that it invokes the CLipboard methods or at least gets the same results as the Clipboard does.

@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Oct 11, 2024
@paul1956 paul1956 changed the title Adds code coverage to ClipboardProxy from PR #11863 Add code coverage to ClipboardProxy from PR #11863 Oct 12, 2024
@paul1956 paul1956 changed the title Add code coverage to ClipboardProxy from PR #11863 Code Coverage for ClipboardProxy from PR #11863 Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants