Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BoolData in Tests #12275

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

paul1956
Copy link
Contributor

@paul1956 paul1956 commented Oct 5, 2024

Cleanup Tests from previous PR

Proposed changes

  • Use BoolData

Customer Impact

  • None trivial simplification of Theory Test

Regression?

  • No

Risk

  • None
Microsoft Reviewers: Open in CodeFlow

@paul1956 paul1956 requested a review from a team as a code owner October 5, 2024 00:01
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, test failure is unrelated.

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.43989%. Comparing base (efe6e11) to head (75afe32).
Report is 5 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12275         +/-   ##
===================================================
- Coverage   75.43993%   75.43989%   -0.00004%     
===================================================
  Files           3103        3104          +1     
  Lines         634302      634313         +11     
  Branches       46875       46876          +1     
===================================================
+ Hits          478517      478525          +8     
+ Misses        152366      152364          -2     
- Partials        3419        3424          +5     
Flag Coverage Δ
Debug 75.43989% <ø> (-0.00004%) ⬇️
integration 17.98485% <ø> (+0.00266%) ⬆️
production 48.82941% <ø> (-0.00160%) ⬇️
test 97.02506% <ø> (+0.00011%) ⬆️
unit 45.86060% <ø> (+0.02336%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Tanya-Solyanik Tanya-Solyanik merged commit 0af0312 into dotnet:main Oct 7, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants