Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MIN_ERG_CADENCE created and changed from 20 to 30. #488

Merged
merged 1 commit into from
Nov 5, 2023
Merged

MIN_ERG_CADENCE created and changed from 20 to 30. #488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed
- Updated communications overview picture.
- Updated kit purchasing links.
- MIN_ERG_CADENCE created and changed from 20 to 30.

### Hardware
- Wire diameter reduced from 7.2mm to 6.0mm on the window passthrough to accommodate the latest batch of cables.
Expand Down
3 changes: 3 additions & 0 deletions include/settings.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,9 @@
// Amount to change watt target per shift in ERG mode.
#define ERG_PER_SHIFT 10

//Minimum cadence where ERG mode stops.
#define MIN_ERG_CADENCE 30

// Default Min Watts to stop stepper.
// This is used to set the lower travel limit for the motor.
#define DEFAULT_MIN_WATTS 50
Expand Down
2 changes: 1 addition & 1 deletion src/ERG_Mode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,7 @@ void ErgMode::_updateValues(int newCadence, Measurement& newWatts, float newIncl
}

bool ErgMode::_userIsSpinning(int cadence, float incline) {
if (cadence <= 20) {
if (cadence <= MIN_ERG_CADENCE) {
if (!this->engineStopped) { // Test so motor stop command only happens once.
ss2k.motorStop(); // release tension
rtConfig.setTargetIncline(incline - WATTS_PER_SHIFT); // release incline
Expand Down
Loading