Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api key creation #7

Merged
merged 7 commits into from
Jun 12, 2024
Merged

Api key creation #7

merged 7 commits into from
Jun 12, 2024

Conversation

mdellabitta
Copy link
Contributor

@mdellabitta mdellabitta commented Jun 12, 2024

🚀 This description was created by Ellipsis for commit 534d8d4

Summary:

This PR introduces API key creation and management, including database setup, email notifications, and necessary backend logic.

Key points:

  • Added public.account table in db-scripts/init.sql for API key management.
  • Updated docker-compose.yml to mount database scripts and configure the Postgres service.
  • Included new dependency @aws-sdk/client-ses in package.json for email handling.
  • Implemented Emailer class in src/aggregation/Emailer.ts to facilitate email sending.
  • Updated src/aggregation/api_key_repository.ts to include methods for API key creation and retrieval.
  • Added new API endpoint in src/index.ts for API key creation requests.

Generated with ❤️ by ellipsis.dev

Copy link

gitguardian bot commented Jun 12, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11033179 Triggered Generic Password 5c6f74c docker-compose.yml View secret
11033179 Triggered Generic Password 5c6f74c docker-compose.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 534d8d4 in 1 minute and 30 seconds

More details
  • Looked at 444 lines of code in 8 files
  • Skipped 1 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_gV3I8dW5ed9zpSeg


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

src/index.ts Outdated Show resolved Hide resolved
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
@mdellabitta mdellabitta merged commit c8f66e3 into main Jun 12, 2024
3 of 4 checks passed
@mdellabitta mdellabitta deleted the api-key-creation branch June 12, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant