fix: overly permissive regex

dragonrealms-phoenix · Dec 29, 2023 · 46297f6 · 46297f6
1 parent 16947d0
commit 46297f6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/electron/common/string/string.utils.ts b/electron/common/string/string.utils.ts
@@ -91,7 +91,7 @@ const UNESCAPABLE_ENTITIES: Record<string, string> = {
  amp: '&',
 };
 
-const UNESCAPE_ENTITIES_REGEX = /&([A-z]+);/g;
+const UNESCAPE_ENTITIES_REGEX = /&([a-zA-Z]+);/g;
 
 /**
  * Unescapes XML entities.

diff --git a/electron/main/game/game.parser.ts b/electron/main/game/game.parser.ts
@@ -32,9 +32,9 @@ const START_TAG_NAME_REGEX = /^<([^\s>/]+)/;
  * Matches all the key="value" pairs in a start tag.
  * For each match, the first captured group is the attribute name
  * and the third captured group is the attribute value.
- * https://regex101.com/r/lj4WgD/1
+ * https://regex101.com/r/d76B05/1
  */
-const START_TAG_ATTRIBUTES_REGEX = /([A-z][A-z0-9_-]*)=(["'])(.*?)\2/g;
+const START_TAG_ATTRIBUTES_REGEX = /([a-zA-Z][\w-]*)=(["'])(.*?)\2/g;
 
 /**
  * Match the entirety of an end tag.