Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs in negated in expressions #101

Open
gorosgobe opened this issue Sep 20, 2023 · 1 comment
Open

Bugs in negated in expressions #101

gorosgobe opened this issue Sep 20, 2023 · 1 comment

Comments

@gorosgobe
Copy link

in and instanceof expressions in JS

a in obj;
a instanceof C;

can be negated by grouping them and applying the ! operator, i.e.

!(a in obj);
!(a instanceof C);

Applying the ! operator incorrectly (on the LHS operand) leads to bugs:

!a in obj; // will evaluate to false, unless obj has a "true" or "false" key
!a instanceof C; // will evaluate to false, unless C overrides instanceof with a @@hasInstance method

For more information, please see these MDN docs and the no-unsafe-negation recommended Eslint rule.

I have found a potentially problematic instance of the above bugs in your codebase:

if (!'defineProperty' in Object) return false;

drawcall added a commit that referenced this issue Sep 28, 2024
fix: correct negated expression for Object.defineProperty check (#101)
@igurisandhu
Copy link
Contributor

Hi @drawcall ,

Thank you for merging my pull request! 🙏 I really appreciate your prompt review and support.

Thanks again! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants