-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugs in negated in
expressions
#101
Comments
igurisandhu
added a commit
to igurisandhu/Proton
that referenced
this issue
Sep 27, 2024
drawcall
added a commit
that referenced
this issue
Sep 28, 2024
fix: correct negated expression for Object.defineProperty check (#101)
Hi @drawcall , Thank you for merging my pull request! 🙏 I really appreciate your prompt review and support. Thanks again! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
in
andinstanceof
expressions in JScan be negated by grouping them and applying the
!
operator, i.e.Applying the
!
operator incorrectly (on the LHS operand) leads to bugs:For more information, please see these MDN docs and the no-unsafe-negation recommended Eslint rule.
I have found a potentially problematic instance of the above bugs in your codebase:
Proton/example/game/crafty/js/crafty.js
Line 4306 in 83c3caa
The text was updated successfully, but these errors were encountered: