Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sheet): add custom for row and column #3693

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Oct 10, 2024

Worksheet API

  • setRowCustom
  • setColumnCustom

Docs

dream-num/univer.ai#321

How to test?

univerAPI.getActiveWorkbook().getActiveSheet().setRowCustom({1: {color: 'red'}})
// or
univerAPI.getActiveWorkbook().getActiveSheet().setColumnCustom({1: {color: 'red'}})

check snapshot

univerAPI.getActiveWorkbook().getSnapshot()

image

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Oct 10, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Dushusir Dushusir marked this pull request as ready for review October 10, 2024 10:17
@Dushusir Dushusir added the qa:untested This PR is ready to be tested label Oct 10, 2024
Copy link

github-actions bot commented Oct 10, 2024

Playwright test results

passed  16 passed
flaky  1 flaky

Details

stats  17 tests across 8 suites
duration  4 minutes, 45 seconds
commit  ab5de86
info  For more information, see full report

Flaky tests

chromium › disposing/disposing.spec.ts › no error on constructing and disposing sheet unit

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 97.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 31.00%. Comparing base (9aad18a) to head (ab5de86).

Files with missing lines Patch % Lines
...ts/src/commands/commands/set-col-custom.command.ts 93.33% 1 Missing ⚠️
...ts/src/commands/commands/set-row-custom.command.ts 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3693      +/-   ##
==========================================
+ Coverage   30.96%   31.00%   +0.03%     
==========================================
  Files        2286     2289       +3     
  Lines      118558   118628      +70     
  Branches    26113    26115       +2     
==========================================
+ Hits        36714    36782      +68     
- Misses      81844    81846       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Oct 12, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants