Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cell style in collaboration #3748

Merged
merged 3 commits into from
Oct 15, 2024
Merged

fix: cell style in collaboration #3748

merged 3 commits into from
Oct 15, 2024

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented Oct 14, 2024

close https:/dream-num/univer-pro/issues/2605

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Oct 14, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Oct 14, 2024
Copy link

github-actions bot commented Oct 14, 2024

Playwright test results

passed  17 passed

Details

stats  17 tests across 8 suites
duration  4 minutes, 6 seconds
commit  2362beb
info  For more information, see full report

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 30.98%. Comparing base (555e9d5) to head (2362beb).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...sheets/src/commands/commands/move-range.command.ts 90.90% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3748   +/-   ##
=======================================
  Coverage   30.97%   30.98%           
=======================================
  Files        2281     2281           
  Lines      118454   118463    +9     
  Branches    26110    26112    +2     
=======================================
+ Hits        36693    36701    +8     
- Misses      81761    81762    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku removed the qa:untested This PR is ready to be tested label Oct 15, 2024
Copy link
Contributor

@yuhongz yuhongz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lumixraku lumixraku merged commit e138b95 into dev Oct 15, 2024
9 checks passed
@lumixraku lumixraku deleted the fix/colla-style branch October 15, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants