Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix permission rangeSelector & insert menu #3757

Merged
merged 5 commits into from
Oct 17, 2024
Merged

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Oct 15, 2024

close https:/dream-num/univer-pro/issues/2874

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Oct 15, 2024
Copy link

github-actions bot commented Oct 15, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Oct 15, 2024

Playwright test results

passed  17 passed

Details

stats  17 tests across 8 suites
duration  4 minutes, 6 seconds
commit  a45d50d
info  For more information, see full report

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 30.97%. Comparing base (e16ead3) to head (a45d50d).
Report is 19 commits behind head on dev.

Files with missing lines Patch % Lines
...ets-ui/src/views/permission/panel-detail/index.tsx 0.00% 4 Missing ⚠️
...ers/permission/sheet-permission-init.controller.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3757      +/-   ##
==========================================
- Coverage   31.00%   30.97%   -0.03%     
==========================================
  Files        2280     2281       +1     
  Lines      118356   118486     +130     
  Branches    26088    26122      +34     
==========================================
+ Hits        36693    36703      +10     
- Misses      81663    81783     +120     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -344,16 +346,17 @@ export const SheetPermissionPanelDetail = ({ fromSheetBar }: { fromSheetBar: boo
<FormLayout className={styles.sheetPermissionPanelTitle} label={localeService.t('permission.panel.protectedRange')}>
{RangeSelector && (
<RangeSelector
key={rangeStr}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是干啥- - ?

@zhaolixin7 zhaolixin7 added qa:rejected and removed qa:untested This PR is ready to be tested labels Oct 15, 2024
@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:rejected labels Oct 15, 2024
@ybzky ybzky merged commit 1f43484 into dev Oct 17, 2024
9 checks passed
@ybzky ybzky deleted the fix-permission-insert branch October 17, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants