DX-82852: Nullify fieldReader when cleaning up listreader. #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https:/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or In the case of PARQUET issues on JIRA the title also supports: See also: |
lriggs
changed the title
xxlaykxx
pushed a commit
that referenced
this pull request
Oct 29, 2023
DenisTarasyuk
pushed a commit
that referenced
this pull request
Dec 19, 2023
DenisTarasyuk
pushed a commit
that referenced
this pull request
Jan 16, 2024
DenisTarasyuk
pushed a commit
that referenced
this pull request
Mar 6, 2024
DenisTarasyuk
pushed a commit
that referenced
this pull request
Mar 7, 2024
lriggs
added a commit
to lriggs/arrow
that referenced
this pull request
Mar 12, 2024
lriggs
added a commit
to lriggs/arrow
that referenced
this pull request
Apr 25, 2024
stevelorddremio
pushed a commit
to stevelorddremio/arrow
that referenced
this pull request
Jun 14, 2024
lriggs
added a commit
to lriggs/arrow
that referenced
this pull request
Sep 3, 2024
lriggs
added a commit
to lriggs/arrow
that referenced
this pull request
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After submitting Cherry pick Gh 15187 into dremio 24.3 12 (#47) · dremio/arrow@c2ad17b , Jeremy ran into an issue with a test he was writing failing. WIP: https://gerrit.drem.io/gerrit/c/dremio/+/55212
After extensive debugging Jeremy and I determined that the fieldReader object was being left behind and causing some odd behavior in the unit test.
https://dremio.atlassian.net/browse/DX-82852