Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-40968: [C++][Gandiva] add RE2::Options set_dot_nl(true) for Like … #68

Merged
merged 1 commit into from
Apr 12, 2024
Merged

GH-40968: [C++][Gandiva] add RE2::Options set_dot_nl(true) for Like … #68

merged 1 commit into from
Apr 12, 2024

Commits on Apr 12, 2024

  1. apacheGH-40968: [C++][Gandiva] add RE2::Options set_dot_nl(true) for … 

    …Like function (apache#40970)

### Rationale for this change

Gandiva function "LIKE" does not always work correctly when the string contains \n.
String value:
`[function_name: "Space1.protect"\nargs: "passenger_count"\ncolumn_name: "passenger_count" ]`
Pattern '%Space1%' nor '%Space1.%' do not match.

### What changes are included in this PR?

added flag set_dot_nl(true) to LikeHolder

### Are these changes tested?

add unit tests.

### Are there any user-facing changes?
Yes

**This PR includes breaking changes to public APIs.**

* GitHub Issue: apache#40968

Lead-authored-by: Ivan Chesnov <[email protected]>
Co-authored-by: Ivan Chesnov <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
    @xxlaykxx
    xxlaykxx committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    e3927e4 View commit details
    Browse the repository at this point in the history