GH-38879: [C++][Gandiva] Fix Gandiva to_date function's validation for supress errors parameter (#38987) #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenisTarasyuk
commented
May 15, 2024
DenisTarasyuk
commented
…ion for supress errors parameter (apache#38987) * This PR fixes the `to_date_utf8_utf8_int32` gandiva function to avoid crash for invalid input * A bug fix for to_date_utf8_utf8_int32 parameter validation Yes, new tests are added to verify non literal input won't crash the to_date_utf8_utf8_int32 function No * Closes: apache#38879 Authored-by: Yue Ni <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
|
❌ GitHub issue apache#38879 could not be retrieved. |
lriggs
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.