Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add database, schema, and datalake options to profile creation #53

Closed
jlarue26 opened this issue Nov 1, 2022 · 0 comments · Fixed by #60
Closed

Add database, schema, and datalake options to profile creation #53

jlarue26 opened this issue Nov 1, 2022 · 0 comments · Fixed by #60
Assignees
@jlarue26
Labels
enhancement New feature or request

Comments

@jlarue26
Copy link
Contributor

jlarue26 commented Nov 1, 2022

Update profile_template.yml to add these to the interactively created profiles.

DremioCredentials._ALIASES seems to indicate that track, space. and folder are already supported and mapped to environment. database and schema respectively. Decide what terminology to use, at least in the profile creation.
@jlarue26 jlarue26 self-assigned this Nov 1, 2022
@jlarue26 jlarue26 mentioned this issue Nov 6, 2022
Merged
@jlarue26 jlarue26 linked a pull request Nov 6, 2022 that will close this issue
53 add database schema and datalake options to profile creation #60
Merged
@jlarue26 jlarue26 added the enhancement New feature or request label Nov 6, 2022
jlarue26 added a commit that referenced this issue Nov 9, 2022
@jlarue26 @ArgusLi
53 add database schema and datalake options to profile creation (#60)
5515c85 
### Add new Profile Options

Add profile options that reflect Dremio concepts.

### Description

Existing profile options reflected dbt concepts that did map intuitively
to Dremio concepts, such as `database`, `schema`, etc. Hence, added
profile options that reflect Dremio concepts, and mapped these to the
dbt equivalents.

Added:
- object_storage_source --> datalake
- object_storage_path --> root_folder
- dremio_space --> database
- dremio_space_folder --> schema

### Related Issue

#53

### Additional Reviewers

@ArgusLi 
@ravjotbrar 

### Testing

- /tests/component/test_profile_template.py [new]
- /.github/scripts/smoke_test.sh (all tests)

Co-authored-by: ArgusLi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jlarue26 jlarue26

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

53 add database schema and datalake options to profile creation dremio/dbt-dremio
1 participant
@jlarue26