实现全局锁在 zookeeper下的持久化, 完善 ZookeeperRepository 的相关方法, 并编写相关测试用例 #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #362 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 442 443 +1
Lines 8621 8681 +60
Branches 1417 1428 +11
======================================
- Misses 8621 8681 +60
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cherrylzhao
reviewed
Aug 18, 2023
| @@ -62,11 +62,11 @@ | |||
| public class ZookeeperRepository implements HmilyRepository { | |||
|
|
|||
| private static final Logger LOGGER = LoggerFactory.getLogger(ZookeeperRepository.class); | |||
|
|
|||
cherrylzhao
reviewed
Aug 18, 2023
| @@ -29,7 +28,6 @@ | |||
| * @author xiaoyu | |||
| */ | |||
| @Getter | |||
| @RequiredArgsConstructor | |||
There was a problem hiding this comment.
这里为什么要去掉lombok自动生成构造函数，而自己去写
cherrylzhao
pushed a commit
that referenced
this pull request
Oct 24, 2023
* 实现全局锁在 zookeeper下的持久化, 完善 ZookeeperRepository 的相关方法, 并编写相关测试用例 * HmilyLock类构造方法使用lombok注解@AllArgsConstructor
cherrylzhao
pushed a commit
that referenced
this pull request
Oct 24, 2023
* 实现全局锁在 zookeeper下的持久化, 完善 ZookeeperRepository 的相关方法, 并编写相关测试用例 * HmilyLock类构造方法使用lombok注解@AllArgsConstructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that:
mvn clean install -Dmaven.javadoc.skip=true.for issue #361