Add check in ScheduledReporter's stop method (#4246)

Closes #4135
dropwizard · Oct 3, 2024 · f0bb90d · f0bb90d
1 parent 80a0e2d
commit f0bb90d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/metrics-core/src/main/java/com/codahale/metrics/ScheduledReporter.java b/metrics-core/src/main/java/com/codahale/metrics/ScheduledReporter.java
@@ -220,10 +220,13 @@ public void stop() {
  executor.shutdown(); // Disable new tasks from being submitted
  }
 
- try {
- report(); // Report metrics one last time
- } catch (Exception e) {
- LOG.warn("Final reporting of metrics failed.", e);
+ if (this.scheduledFuture != null) {
+ // Reporter started, try to report metrics one last time
+ try {
+ report();
+ } catch (Exception e) {
+ LOG.warn("Final reporting of metrics failed.", e);
+ }
  }
 
  if (shutdownExecutorOnStop) {

diff --git a/metrics-graphite/src/test/java/com/codahale/metrics/graphite/GraphiteReporterTest.java b/metrics-graphite/src/test/java/com/codahale/metrics/graphite/GraphiteReporterTest.java
@@ -445,6 +445,7 @@ public void closesConnectionIfGraphiteIsUnavailable() throws Exception {
 
  @Test
  public void closesConnectionOnReporterStop() throws Exception {
+ reporter.start(1, TimeUnit.SECONDS);
  reporter.stop();
 
  final InOrder inOrder = inOrder(graphite);