Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds attempt decorator #1217

Merged
merged 6 commits into from
Jan 8, 2022
Merged

Adds attempt decorator #1217

merged 6 commits into from
Jan 8, 2022

Conversation

thepabloaguilar
Copy link
Member

Adds attempt decorator

Checklist

  • I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc)
  • I have created at least one test case for the changes I have made
  • I have updated the documentation for the changes I have made
  • I have added my changes to the CHANGELOG.md

Related issues

Closes #264

@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #1217 (0ad1868) into master (5033f90) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1217   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           79        79           
  Lines         2425      2434    +9     
  Branches       211       211           
=========================================
+ Hits          2425      2434    +9     
Impacted Files Coverage Δ
returns/result.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a6b31e...0ad1868. Read the comment docs.

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you! Only minor suggestions.

I've also removed a test file, because doctests are good enough in this case.

docs/pages/result.rst Outdated Show resolved Hide resolved
typesafety/test_result/test_attempt.yml Show resolved Hide resolved
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thank you!

@sobolevn sobolevn merged commit 5ba9cf7 into master Jan 8, 2022
@sobolevn sobolevn deleted the issue-264 branch January 8, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Variant of safe that preserves the argument that lead to an exception
2 participants