Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong addition solved in add_faux_rows by adding parseInt #426

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rept
Copy link

@rept rept commented Sep 8, 2014

This solves #425.

The
fn.add_faux_rows = function(rows) {
var actual_rows = this.rows;
var max_rows = actual_rows + (rows || 1);

The second part was being added as a string before this patch. This gave a huge row number and caused lots of lags. Now it flies again.

I think also related to:

#340 (see comments of canfiax)

@jhowley89
Copy link

Is it worth doing this to line 3826 as well (columns)?

@rept
Copy link
Author

rept commented Sep 10, 2014

@jhowley1989 good point, probably yes. I didn't experience any problems with it, but I assume this will cause the same problems.

@rept
Copy link
Author

rept commented Sep 10, 2014

@jhowley1989 I also added it to the columns. Hope this will be pulled soon.

@rept
Copy link
Author

rept commented Sep 18, 2014

It was confirmed that this also solves #340 Any idea when this will be pulled?

@mrud
Copy link

mrud commented Oct 29, 2014

I encountered the same issue with the slowdown. This patch fixes it.

@rept
Copy link
Author

rept commented Nov 1, 2014

@mrud great to hear. To bad it isn't being pulled, that would avoid hours of searching for something that is already fixed.

@dsmorse
Copy link

dsmorse commented Apr 8, 2015

Looks great I merged it into my fork dsmorse/gridster.js

vieron pushed a commit to vieron/gridster.js that referenced this pull request Apr 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants