Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Which Markdown Parser? #24

Open
nelsonic opened this issue Nov 2, 2015 · 4 comments
Open

Which Markdown Parser? #24

nelsonic opened this issue Nov 2, 2015 · 4 comments

Comments

@nelsonic
Copy link
Member

nelsonic commented Nov 2, 2015

We are currently using marked because it seemed like the better option at the time we were starting this project ...
But Mr. @alanshaw has opted for _remarkable_ in his project: https:/alanshaw/markdown-pdf

Which one should we be using and why? What makes one "better" than the other?
are there more options to consider or are these the two best ones...?

If anyone has time to do empirical research on this topic it would be incredibly useful! 👍

@alanshaw
Copy link
Member

alanshaw commented Nov 2, 2015

I swapped because for a long time marked was vulnerable and appeared abandoned.

https://david-dm.org/dwyl/adoro

@nelsonic
Copy link
Member Author

nelsonic commented Nov 2, 2015

adoro--security-vulnerabilities-in-dependencies

Wow... that's a lot of RED ink _pixels_...
Ok. for now, we're switching to _remarkable_
and we can always re-visit this issue if anyone spots a performance, security or features issue with using it.

Thanks @alanshaw 👍

@des-des
Copy link
Member

des-des commented Dec 1, 2015

If we are trying to create amp HTML compliant pages (see issue #33) should this be done during or after the md-html conversion? Our current approach is to use remarkable to build html from the markdown. Then, either using the custom rules in remarkable and/or through another conversion make the html amp compliment before inserting it into our template.
Going to start down this route now, any thought appreciated!

@nelsonic
Copy link
Member Author

nelsonic commented Dec 1, 2015

@des-des as verbally discussed, your objective today should be to have a pipeline that converts
MD > HMTL and then Check AMP Compliance
Once you know what non-compliant html tags are generated by your Markdown Parser, you can write a transformer step from the HTML to AMP-HTML (TDD)

jackcarlisle added a commit that referenced this issue Dec 1, 2015
sohilpandya added a commit that referenced this issue Dec 2, 2015
sohilpandya added a commit that referenced this issue Dec 2, 2015
des-des added a commit that referenced this issue Dec 3, 2015
jackcarlisle added a commit that referenced this issue Dec 3, 2015
jackcarlisle added a commit that referenced this issue Dec 3, 2015
This was referenced Dec 3, 2015
@jackcarlisle jackcarlisle mentioned this issue Dec 3, 2015
jackcarlisle added a commit that referenced this issue Dec 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants