Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

team2-master root directory #78

Open
hdrdavies opened this issue Dec 4, 2015 · 3 comments
Open

team2-master root directory #78

hdrdavies opened this issue Dec 4, 2015 · 3 comments
Labels
help wanted

Comments

@hdrdavies
Copy link
Member

Quite a lot of files in the root directory:
-.DS-Store and npm-debug-log can be deleted
-favicon could be in an "assets" folder
-header and footer could be in a "partials" folder
-styling could be included in another folder too if there is to be more extensive styling
@hdrdavies hdrdavies changed the title team2-master team2-master root directory Dec 4, 2015
@iteles
Copy link
Member

iteles commented Dec 4, 2015

@hdrdavies You already have .DS_Store in your .gitignore, but worth getting your debug log in there too.

@hdrdavies
Copy link
Member Author

@iteles it's actually the other team's branch but agree with you 👍

@iteles
Copy link
Member

iteles commented Dec 4, 2015

Ah yes, code reviews 👍 Good on you for actually doing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nelsonic @iteles @hdrdavies