Upgrade from aws-sdk (v2) to @aws-sdk/client-lambda (v3) #85

dwyl · Feb 3, 2024 · e84d079 · e84d079
1 parent 8b1ed15
commit e84d079
Show file tree

Hide file tree

Showing 8 changed files with 3,304 additions and 651 deletions.
diff --git a/dpl.js b/dpl.js
@@ -6,7 +6,7 @@ const dpl = require('./lib/index.js');
 const pkg = require(dpl.utils.getBasepath() + 'package.json');
 dpl.copyfiles(); // copy required files & dirs
 if (pkg.files_to_deploy.indexOf('.env') > -1) {
- dpl.utils.makeEnvFile(); // github.com/numo-labs/aws-lambda-deploy/issues/31
+ dpl.utils.makeEnvFile();
 }
 dpl.install_node_modules(); // install only production node_modules
 dpl.zip(); // zip the /dist directory

diff --git a/lib/upload.js b/lib/upload.js
@@ -1,7 +1,7 @@
 'use strict';
-const AWS = require('aws-sdk');
-AWS.config.region = process.env.AWS_REGION; // set your Environment Variables...
-const lambda = new AWS.Lambda();
+const AWS = require("@aws-sdk/client-lambda");
+const lambda = new AWS.Lambda({ region: process.env.AWS_REGION });
+
 const fs = require('fs'); // so we can read the zip file
 const assert = require('assert');
 const utils = require('../lib/utils');
@@ -22,20 +22,15 @@ module.exports = function upload (pkg, callback) {
  pkg = PKG
  }
  const FUNCTION_NAME = utils.functionName(pkg);
- // try {
- lambda.getFunction({ FunctionName: FUNCTION_NAME }, function (err, data) {
- /* istanbul ignore else */
- if (err) { // if the function does not already exist we create it.
- console.error('upload lambda.getFunction error:', err);
- return lambda.createFunction(createParams(pkg), callback);
- } else { // otherwise update the *existing* lambda function:
- return updateFunction(pkg, callback);
- }
- });
- // } catch (error) {
- // console.error(error);
- // return callback()
- // }
+ lambda.getFunction({ FunctionName: FUNCTION_NAME }, function (err, data) {
+ /* istanbul ignore else */
+ if (err) { // if the function does not already exist we create it.
+ console.error('upload lambda.getFunction error:', err);
+ return lambda.createFunction(createParams(pkg), callback);
+ } else { // otherwise update the *existing* lambda function:
+ return updateFunction(pkg, callback);
+ }
+ });
 };
 
 function createParams (pkg) {

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -71,7 +71,7 @@
  "tape": "^4.13.2"
  },
  "dependencies": {
- "aws-sdk": "^2.1550.0",
+ "@aws-sdk/client-lambda": "^3.504.0",
  "env2": "^2.2.2"
  },
  "semistandard": {

diff --git a/test/000_debug.test.js b/test/000_debug.test.js
@@ -9,9 +9,8 @@ const PKG = require(basepath + 'package.json');
 const FUNCTION_NAME = utils.functionName(PKG);
 console.log('FUNCTION_NAME:', FUNCTION_NAME);
 
-const AWS = require('aws-sdk');
-AWS.config.region = process.env.AWS_REGION; // set your Environment Variables...
-const lambda = new AWS.Lambda();
+const AWS = require("@aws-sdk/client-lambda");
+const lambda = new AWS.Lambda({ region: process.env.AWS_REGION });
 // console.log(' - - - - - - - - - - - - - - - - - - - - - - ');
 // console.log(process);
 // console.log(' - - - - - - - - - - - - - - - - - - - - - - ');

diff --git a/test/03_install_node_modules.test.js b/test/03_install_node_modules.test.js
@@ -9,9 +9,9 @@ test('install production node_modules only', async function (t) {
  const distpath = path.normalize(process.env.TMPDIR + 'dist/');
  copyfiles();
  installnodemodules();
- const awspkg = path.resolve(distpath, 'node_modules/aws-sdk/package.json');
+ const awspkg = path.resolve(distpath, 'node_modules/@aws-sdk/client-lambda/package.json');
  const pkg = require(awspkg);
- t.deepEqual(pkg.name, 'aws-sdk');
+ t.deepEqual(pkg.name, '@aws-sdk/client-lambda');
  utils.deleteDirContents(distpath, true); // cleanup for next test
  t.end();
 });
diff --git a/test/05_upload.test.js b/test/05_upload.test.js
@@ -8,9 +8,9 @@ const utils = require('../lib/utils');
 const fs = require('fs');
 const path = require('path');
 
-const AWS = require('aws-sdk');
-AWS.config.region = process.env.AWS_REGION; // set your Environment Variables...
-const lambda = new AWS.Lambda();
+const AWS = require("@aws-sdk/client-lambda");
+const lambda = new AWS.Lambda({ region: process.env.AWS_REGION });
+
 const basepath = utils.getBasepath();
 const PKG = require(basepath + 'package.json');
 const FUNCTION_NAME = utils.functionName(PKG);

diff --git a/test/06_lambda_settings.test.js b/test/06_lambda_settings.test.js
@@ -10,9 +10,8 @@ const upload = require('../lib/upload');
 const utils = require('../lib/utils');
 
 const basepath = utils.getBasepath();
-const AWS = require('aws-sdk');
-AWS.config.region = process.env.AWS_REGION; // set your Environment Variables...
-const lambda = new AWS.Lambda();
+const AWS = require("@aws-sdk/client-lambda");
+const lambda = new AWS.Lambda({ region: process.env.AWS_REGION });
 let pkg = require(path.resolve(basepath, 'package.json'));
 const FUNCTION_NAME = utils.functionName(pkg);