Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case studies dec17 v2 #440

Merged
merged 8 commits into from
Jan 18, 2018
Merged

Case studies dec17 v2 #440

merged 8 commits into from
Jan 18, 2018

Conversation

rub1e
Copy link
Member

@rub1e rub1e commented Dec 19, 2017

@Cleop - please review to ensure the changes we've made are the right ones

@iteles - just adding you so you can cast your eye over the new copy

@rub1e rub1e requested review from iteles and Cleop December 19, 2017 14:31
@dwylbot
Copy link

dwylbot bot commented Dec 19, 2017

@rub1e, hoorah! 🎉 It's review time! 👀

I couldn't help but notice that there isn't an in-progress label on this pull request and a Reviewer
has been added...makes me think that this pull request is ready for review 🤔

To save you time ⏳ I've added the Reviewer as an Assignee and I've added the awaiting-review
label - automatically - just like magic! 🎩 🐰 ✨. Please correct me if I'm wrong, but if I got it right
this time I hope it helps you! 😄

Any questions, complaints, feedback, contributions?
Discuss
If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new

@dwylbot dwylbot bot added the awaiting-review An issue or pull request that needs to be reviewed label Dec 19, 2017
@dwylbot dwylbot bot assigned Cleop and iteles Dec 19, 2017
@dwylbot
Copy link

dwylbot bot commented Dec 19, 2017

@rub1e, hoorah! 🎉 It's review time! 👀

I couldn't help but notice that there isn't an in-progress label on this pull request and a Reviewer
has been added...makes me think that this pull request is ready for review 🤔

To save you time ⏳ I've added the Reviewer as an Assignee and I've added the awaiting-review
label - automatically - just like magic! 🎩 🐰 ✨. Please correct me if I'm wrong, but if I got it right
this time I hope it helps you! 😄

Any questions, complaints, feedback, contributions?
Discuss
If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new

@dwylbot dwylbot bot added the awaiting-review An issue or pull request that needs to be reviewed label Dec 19, 2017
@rub1e
Copy link
Member Author

rub1e commented Dec 19, 2017

Gosh isn't dwyl-bot clever!

Why did it admonish me twice though - is that because I added two reviewers? Is this the sort of behaviour I should open an issue about?

@SimonLab
Copy link
Member

@rub1e an issue already exists for dwylbot dwyl/dwylbot#129, I need to sit down and review/clean the dwylbot code

Copy link
Member

@Cleop Cleop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing 😄 nice one Rubie!

@Cleop Cleop removed their assignment Dec 22, 2017
Copy link
Member

@iteles iteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a couple of small changes to add here on content, will do so in the morning!

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rub1e LGTM! 👍

Copy link
Member

@iteles iteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a couple of tiny (pretty much formatting) changes, thanks @rub1e !

@iteles iteles merged commit 8991680 into master Jan 18, 2018
@iteles iteles deleted the case-studies-dec17-v2 branch January 18, 2018 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review An issue or pull request that needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants