Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't assign reviewer until CI has passed #156

Open
Danwhy opened this issue Aug 25, 2017 · 1 comment
Open

Don't assign reviewer until CI has passed #156

Danwhy opened this issue Aug 25, 2017 · 1 comment

Comments

@Danwhy
Copy link
Member

Danwhy commented Aug 25, 2017

Currently dwylbot can both assign people to review PRs, and alert you when your CI has passed. Would it be possible for dwylbot to only assign the reviewer to the pull request once the CI has passed?

This way, the person opening the PR can add an awaiting review label and request a review, then not have to worry about coming back to check that the CI has passed before assigning. This would save time for the person opening the PR, allowing them to get back to work straight away, and means the reviewer won't get alerted to review a failing build.

@ghost ghost added the question label Aug 25, 2017
@ghost ghost assigned SimonLab and naazy Aug 25, 2017
@ghost ghost added the priority-3 label Aug 25, 2017
@ghost
Copy link

ghost commented Aug 25, 2017

@Danwhy thanks for the suggestion! I imagine this is probably possible... @SimonLab / @naazy to confirm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants