Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep in-progress label on merge-conflict #137 #144

Merged
merged 1 commit into from
Sep 1, 2017

Conversation

naazy
Copy link
Member

@naazy naazy commented Aug 9, 2017

keep in-progress label on merge-conflict #137

@dwylbot
Copy link

dwylbot bot commented Aug 9, 2017

@naazy, a reviewer has been added to the pull request.
The pull request looks ready for review (no "in-progress" label).
So the reviewer has been added as an assignee and the "awaiting-reivew" label as been added to.

Any questions, complaints, feedback, contributions?
Discuss
If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new

@codecov
Copy link

codecov bot commented Aug 9, 2017

Codecov Report

Merging #144 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
+ Coverage   98.32%   98.33%   +<.01%     
==========================================
  Files          23       23              
  Lines         179      180       +1     
==========================================
+ Hits          176      177       +1     
  Misses          3        3
Impacted Files Coverage Δ
web/controllers/rules/pr/merge_conflict.ex 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79e802e...38692fe. Read the comment docs.

@iteles iteles assigned SimonLab, Danwhy and samhstn and unassigned SimonLab Aug 18, 2017
@iteles
Copy link
Member

iteles commented Aug 18, 2017

Adding @Danwhy and @Shouston3 as potential reviewers as they've shown interest in dwylbot in the past. If you guys have some spare time during the workday, please take a look 😊

Copy link
Member

@samhstn samhstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Are there tests for these?

@samhstn samhstn removed the in-review label Aug 18, 2017
@samhstn samhstn removed their assignment Aug 18, 2017
@naazy
Copy link
Member Author

naazy commented Aug 18, 2017

@Shouston3 re tests: #154

@naazy naazy assigned samhstn and unassigned SimonLab and Danwhy Sep 1, 2017
Copy link
Member

@samhstn samhstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I think it's fine for now

@samhstn samhstn merged commit e119e54 into master Sep 1, 2017
@samhstn samhstn deleted the keepInProgressLabelOnMergeConflict branch September 1, 2017 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants