Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correcting wording on PR message #149 #153

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

correcting wording on PR message #149 #153

wants to merge 8 commits into from

Conversation

naazy
Copy link
Member

@naazy naazy commented Aug 18, 2017

correcting wording on PR message #149

@dwylbot
Copy link

dwylbot bot commented Aug 18, 2017

@naazy, hoorah! 🎉 It's review time! 👀

I couldn't help but notice that there isn't an in-progress label on this pull request and a Reviewer
has been added...makes me think that this pull request is ready for review 🤔

To save you time ⏳ I've added the Reviewer as an Assignee and I've added the awaiting-review
label - automatically - just like magic! 🎩 🐰 ✨. Please correct me if I'm wrong, but if I got it right
this time I hope it helps you! 😄

Any questions, complaints, feedback, contributions?
Discuss
If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new

@dwylbot
Copy link

dwylbot bot commented Aug 18, 2017

@naazy, hoorah! 🎉 It's review time! 👀

I couldn't help but notice that there isn't an in-progress label on this pull request and a Reviewer
has been added...makes me think that this pull request is ready for review 🤔

To save you time ⏳ I've added the Reviewer as an Assignee and I've added the awaiting-review
label - automatically - just like magic! 🎩 🐰 ✨. Please correct me if I'm wrong, but if I got it right
this time I hope it helps you! 😄

Any questions, complaints, feedback, contributions?
Discuss
If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new

1 similar comment
@dwylbot
Copy link

dwylbot bot commented Aug 18, 2017

@naazy, hoorah! 🎉 It's review time! 👀

I couldn't help but notice that there isn't an in-progress label on this pull request and a Reviewer
has been added...makes me think that this pull request is ready for review 🤔

To save you time ⏳ I've added the Reviewer as an Assignee and I've added the awaiting-review
label - automatically - just like magic! 🎩 🐰 ✨. Please correct me if I'm wrong, but if I got it right
this time I hope it helps you! 😄

Any questions, complaints, feedback, contributions?
Discuss
If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new

@codecov
Copy link

codecov bot commented Aug 18, 2017 •
edited
Loading

Codecov Report

Merging #153 into master will decrease coverage by 1.43%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
- Coverage   98.32%   96.89%   -1.44%     
==========================================
  Files          23       23              
  Lines         179      193      +14     
==========================================
+ Hits          176      187      +11     
- Misses          3        6       +3
Impacted Files Coverage Δ
web/controllers/github_api/in_memory.ex 100% <ø> (ø) ⬆️
web/controllers/rules/pr/awaiting_review.ex 88.88% <100%> (-11.12%) ⬇️
web/models/user.ex 50% <0%> (-50%) ⬇️
web/controllers/rules/issue/time_estimation.ex 100% <0%> (ø) ⬆️
web/controllers/rules/pr/merge_conflict.ex 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d1b10f...0175cfe. Read the comment docs.

samhstn
samhstn approved these changes Aug 18, 2017
View reviewed changes
Copy link
Member

@samhstn samhstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @naazy 👍

web/controllers/rules/pr/awaiting_review.ex Outdated
@@ -20,6 +20,9 @@ defmodule Dwylbot.Rules.PR.AwaitingReview do
reviewers = payload["pull_request"]["requested_reviewers"]
|> Enum.map(&(&1["login"]))

assignees = get_assignees_login(payload["issue"]["assignees"])
allReviewersWereAssigned? = Enum.all?(reviewers, fn(x) -> Enum.member?(assignees, x) end)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If your using x as a function arg, consider just using function captures instead.

allReviewersWereAssigned? = Enum.all?(reviewers, &Enum.member?(assignees, &1))

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one thanks @Shouston3. Will make the change now 😄

@dwylbot
Copy link

dwylbot bot commented Aug 18, 2017

⚠️ @naazy, the pull request is in "awaiting-review" but some tests are failing.
Please fix the tests and reassign when ready 👍
Thanks

Any questions, complaints, feedback, contributions?
Discuss
If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new

1 similar comment
@dwylbot
Copy link

dwylbot bot commented Aug 18, 2017

⚠️ @naazy, the pull request is in "awaiting-review" but some tests are failing.
Please fix the tests and reassign when ready 👍
Thanks

Any questions, complaints, feedback, contributions?
Discuss
If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new

@dwylbot dwylbot bot assigned naazy and unassigned SimonLab, Danwhy and samhstn Aug 18, 2017
@dwylbot
Copy link

dwylbot bot commented Aug 18, 2017

⚠️ @naazy, the pull request is in "awaiting-review" but some tests are failing.
Please fix the tests and reassign when ready 👍
Thanks

Any questions, complaints, feedback, contributions?
Discuss
If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new

@dwylbot dwylbot bot removed the awaiting-review label Aug 18, 2017
@samhstn samhstn assigned SimonLab and Danwhy and unassigned naazy Aug 18, 2017
@dwylbot
Copy link

dwylbot bot commented Aug 18, 2017

⚠️ @naazy, the pull request is in "awaiting-review" but some tests are failing.
Please fix the tests and reassign when ready 👍
Thanks

Any questions, complaints, feedback, contributions?
Discuss
If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new

@dwylbot
Copy link

dwylbot bot commented Aug 18, 2017

⚠️ @naazy, the pull request is in "awaiting-review" but some tests are failing.
Please fix the tests and reassign when ready 👍
Thanks

Any questions, complaints, feedback, contributions?
Discuss
If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new

2 similar comments
@dwylbot
Copy link

dwylbot bot commented Aug 18, 2017

⚠️ @naazy, the pull request is in "awaiting-review" but some tests are failing.
Please fix the tests and reassign when ready 👍
Thanks

Any questions, complaints, feedback, contributions?
Discuss
If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new

@dwylbot
Copy link

dwylbot bot commented Aug 18, 2017

⚠️ @naazy, the pull request is in "awaiting-review" but some tests are failing.
Please fix the tests and reassign when ready 👍
Thanks

Any questions, complaints, feedback, contributions?
Discuss
If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new

@naazy
Copy link
Member Author

naazy commented Aug 18, 2017

Not quite sure why coverage has suddenly dropped 😢

@naazy naazy assigned samhstn and unassigned naazy Sep 1, 2017
samhstn
samhstn requested changes Sep 1, 2017
View reviewed changes
Copy link
Member

@samhstn samhstn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naazy if you look at adding a test for when all reviews are assigned we'll reach 100% coverage

@samhstn samhstn assigned naazy and unassigned samhstn Sep 1, 2017
@naazy naazy assigned SimonLab and unassigned naazy Sep 1, 2017
@naazy naazy requested a review from SimonLab September 1, 2017 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samhstn samhstn samhstn requested changes

@SimonLab SimonLab Awaiting requested review from SimonLab

Requested changes must be addressed to merge this pull request.

Assignees

@SimonLab SimonLab

Labels
in-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@naazy @samhstn @SimonLab @Danwhy