Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft Account OAuth #1

Closed
4 tasks
nelsonic opened this issue Feb 7, 2015 · 7 comments
Closed
4 tasks

Microsoft Account OAuth #1

nelsonic opened this issue Feb 7, 2015 · 7 comments
Assignees
Labels
discuss Share your constructive thoughts on how to make progress with this issue elixir Pull requests that update Elixir code enhancement New feature or enhancement of existing functionality epic A feature idea that is large enough to require a sprint (5 days) or more and has smaller sub-issues. help wanted If you can help make progress with this issue, please comment! in-progress An issue or pull request that is being worked on by the assigned person priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished T1d Time Estimate 1 Day technical A technical issue that requires understanding of the code, infrastructure or dependencies

Comments

@nelsonic
Copy link
Member

nelsonic commented Feb 7, 2015

Create Microsoft Auth so that I can authenticate with my Microsoft Account.

There are 1.4 Billion active devices running Windows 10 or 11:
https://news.microsoft.com/bythenumbers/en/windowsdevices

image

This doesn't actually tell us anything about how many "On Microsoft" accounts there are ... gotta keep digging.

Statista is usually pretty reliable. Over 1.3 Million companies use Microsoft Office 365:
https://www.statista.com/statistics/983321/worldwide-office-365-user-numbers-by-country/
image

Some companies are much bigger than others.
But if conservatively each company has 100 people, then it's over 100 million people.

https://www.lifewire.com/how-many-email-users-are-there-1171213
image

Understanding Microsoft Business And Personal Accounts:
https://www.bruceb.com/2020/10/understanding-microsoft-business-and-personal-accounts/
image

Todo

Pick-up:

@nelsonic nelsonic added enhancement New feature or enhancement of existing functionality help wanted If you can help make progress with this issue, please comment! labels Feb 7, 2015
@nelsonic nelsonic changed the title Write basic node.js app intro shipping to Heroku Write Basic Auth Code and Ship Demo to Heroku Mar 28, 2022
@nelsonic nelsonic changed the title Write Basic Auth Code and Ship Demo to Heroku Microsoft Account OAuth Mar 28, 2022
@nelsonic nelsonic self-assigned this Mar 28, 2022
@nelsonic
Copy link
Member Author

Wish I'd had time to do this while I was still doing my FinTech Consulting 🧑‍💻
[so I had a couple of MSFT accounts I could test with ...] 🧪

But it's all good; still know plenty of people we can call to help Beta Test this once it's working. 👌

@LuchoTurtle how confident do you feel about your Elixir skills? 🦄
Want to discuss this as a potential mini-project to work on? 💬
Much of the code can be "borrowed" from our existing repos as noted in the OP ⬆️
If we can get Microsoft Auth working ahead of the Auth Rebuild dwyl/auth#207 🔜
it would be awesome to include it as the "3rd option" for people to authenticate to our App. 🤞

@nelsonic nelsonic assigned LuchoTurtle and unassigned nelsonic Oct 14, 2022
@nelsonic nelsonic added epic A feature idea that is large enough to require a sprint (5 days) or more and has smaller sub-issues. discuss Share your constructive thoughts on how to make progress with this issue priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished technical A technical issue that requires understanding of the code, infrastructure or dependencies T1d Time Estimate 1 Day elixir Pull requests that update Elixir code labels Oct 14, 2022
@nelsonic nelsonic added the in-progress An issue or pull request that is being worked on by the assigned person label Oct 14, 2022
@nelsonic
Copy link
Member Author

@LuchoTurtle please remember to leave comments on the issue you're working on through the day. 💬 🙏
And before you leave your desk/office git push your code to GitHub so that it's saved. 💾
I once lost a whole day's work when my I forgot to git push and my laptop died ... it was painful. 😢

@LuchoTurtle
Copy link
Member

@nelsonic Sorry about that! Here's a quick rundown:

I spent most of the time actually battling with Azure Portal and understanding the flow of execution. I think I explained most of the setup needed so far in the guide I'm writing as I'm developing.
I realised that at first I was doing an implicit grant flow, where ID tokens and access tokens are returned directly from the /authorize endpoint instead of the /token endpoint.

But after scouring through the documentation, I realised this wasn't the best idea since it wasn't the most secure option when compared with the classic auth code flow thru OpenID Connect. So I had to redo some things to make it work.

And yes, I pushed most of my code to a different branch. I can't push directly to main because I don't have access and it's a protected branch 😉

@nelsonic
Copy link
Member Author

Yeah, we don't tend to push to main.
Your microsoft-auth looks good. 👍

image

Does MSFT OAuth require you to use the Azure Portal? 💭
Not going to step on your toes while you're working. 👌
But make sure you share your progress as comments so you don't forget anything. ✍️

@LuchoTurtle
Copy link
Member

LuchoTurtle commented Oct 14, 2022

Does MSFT OAuth require you to use the Azure Portal? 💭

Yes it does! The same way you have to register an application when authenticating with Google, you ought to use Active Directory so our application has something to authenticate into 🤔 (AD is inside Azure Portal, amongst a myriad of other services).

@nelsonic
Copy link
Member Author

Cool. That was my suspicion through superficial reading of the docs, but you spent a lot more time with them yesterday - to the point of being our new "expert"! - so thank you for confirming. 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Share your constructive thoughts on how to make progress with this issue elixir Pull requests that update Elixir code enhancement New feature or enhancement of existing functionality epic A feature idea that is large enough to require a sprint (5 days) or more and has smaller sub-issues. help wanted If you can help make progress with this issue, please comment! in-progress An issue or pull request that is being worked on by the assigned person priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished T1d Time Estimate 1 Day technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
Status: Done
Development

No branches or pull requests

2 participants