"PRs are discussion threads for code reviews"

[iteles]

@pm5k described PRs in a great way today which was very clear to the group assembled. Something to the effect of "Look at PRs as a discussion for code review; there's a review, changes are discussed, changes are made and then the code is accepted".

[pm5k]

I don't think I did my thought justice with that one though. I guess for me a PR is a prompt for collaboration, discussion and peer review as much as it is a showcase of someone's hard work which is supposed to be going upstream. It gives people a chance to reason about solutions with each other and ascertain that what gets merged has been done in a satisfactory manner. (I know people tend to shun that word, but "satisfactory" needn't be synonymous with bad, not good enough or imperfect).