Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prescriptive vs Open Comments? #3

Open
iteles opened this issue Oct 3, 2023 · 4 comments
Open

Prescriptive vs Open Comments? #3

iteles opened this issue Oct 3, 2023 · 4 comments
Labels
question A question needs to be answered before progress can be made on this issue

Comments

@iteles
Copy link
Member

iteles commented Oct 3, 2023

The main functionality for this #1 as per the Figma designs is looking great.
(I know we are, at the time of writing, missing the screens that allow for the conversations to be reviewed/searched, but so far the initial UX flow of finding an object, taking a photo and replying looks good).

It's simple and usable.

I see the utility of an open comment as the reply to where something goes:
image

I was wondering if for the MVP, we'd like to be a little more prescriptive in the format of the reply so that we can store locations separately:
image

Reasons we might want to store locations separately:

  • Having a list of locations is the foundation of an organisational system
  • Next feature: grabbing a list of everything that needs to be put away in one specific location (yes, I realise we'll end up with duplicates with slightly different descriptions or spellings at this stage but it's not an MVP problem)
  • Auto-fill later on
  • Interesting data to hold with multiple future applications!

I know that in future we can just pull this information out of comment text, my question is whether for the MVP it may be useful to already classify data as 'location' (and hence this suggestion).

Couldn't find a discuss label so went with question.

@iteles iteles added the question A question needs to be answered before progress can be made on this issue label Oct 3, 2023
@nelsonic
Copy link
Member

nelsonic commented Oct 3, 2023

@iteles totally agree that the object schema should have a location field
that anyone - but ideally the owner of the object - can set/update.

Right now we're just trying to get feature parity with Instant Messaging
so we can ship something and start using it.
But the addition of a location field makes perfect sense
if we want to immediately know where something belongs.

And if/when you cannot "find" a label, it's because it's a new repository
and the labels haven't yet been synced. feel free to: https://labels.fly.dev 👌

@nelsonic
Copy link
Member

nelsonic commented Oct 4, 2023

I've updated the wireframes in Figma to include the location field more prominently: 👌

image

Going to continue with documenting and building the tidy [MVP] App. 🧑‍💻

@iteles it looks like you made an update to the layout in Figma, did you then DELETE it? 🤷‍♂️
Please leave your edits/suggestions on the page as it speeds up collaboration. 🙏

@LuchoTurtle
Copy link
Member

An implementation detail question: will the authentication be made through a web view?

@nelsonic
Copy link
Member

nelsonic commented Oct 4, 2023

For now, yes, the way Figma does it. 😉
While I would love to have time to port this to Flutter we must focus on our main App. 🎯
Only building this so that we can use it internally for now ...
Just going to build this as a LiveView mini-app using our existing auth flow. 🔐 ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question A question needs to be answered before progress can be made on this issue
Projects
None yet
Development

No branches or pull requests

3 participants