Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameSettings.java declaration mixup #5

Open
SeasonalFerret opened this issue Apr 19, 2023 · 7 comments
Open

GameSettings.java declaration mixup #5

SeasonalFerret opened this issue Apr 19, 2023 · 7 comments
Labels
bug Something isn't working

Comments

@SeasonalFerret
Copy link

From #4, new issue for tracking reasons.

Issue is reproduceable with new installation of mcp1.8.9op after running setup.bat
setup.bat output: https://hastebin.com/share/ifesorokoc.vbnet

image

@dxxxxy
Copy link
Owner

dxxxxy commented Apr 19, 2023

Everything is kinda shifted. The mappings are likely messed up although this shouldn't happen unless Minecraft's source code has been updated (or the source isn't official).

You can see the difficulty field is a Minecraft object and EnumDifficulty is further down below. Same thing for Keybinding, it's shifted by one position in order.

@SeasonalFerret
Copy link
Author

SeasonalFerret commented Apr 19, 2023

Did you manage to reproduce this yourself?

@SeasonalFerret
Copy link
Author

SeasonalFerret commented Apr 19, 2023

May be caused by public boolean hideGUI;, as this line does not appear in my GameSettings.java and some stuff is oddly shifted
image

@SeasonalFerret
Copy link
Author

There's also " private static final String __OBFID = "CL_00000650";" that fails to appear, which coincidentally happens to be where the shifting stops.
I'm unsure if it's related, but both this line and hideGUI don't appear to be referenced anywhere else.

It's taken a while, but I've manually fixed my source.

@dxxxxy
Copy link
Owner

dxxxxy commented Apr 19, 2023

I've managed to reproduce the error, but it was working before because I have an old project with the correct fields.

image

image

It seems the first field had logger skipped over.

@dxxxxy
Copy link
Owner

dxxxxy commented Apr 19, 2023

@SylveonBottle I've investigated and found that it's actually because of Optifine, which means this error has been present for a long time now... I can't believe I never noticed it.

You can see it right here: https:/DxxxxY/mcp1.8.9op/blob/master/op/net/minecraft/client/settings/GameSettings.java

@dxxxxy
Copy link
Owner

dxxxxy commented Apr 19, 2023

@SylveonBottle I could downgrade to the previous version which my old project used or you can paste your changes and open a pull request. I severely doubt that this happens in every file though...

@dxxxxy dxxxxy added the bug Something isn't working label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants