Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Improve wayland wm detection #2430

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jcorbin
Copy link

@jcorbin jcorbin commented Dec 29, 2023

Description

On my arch system running the river wm, get_wm wasn't working.

First off, I'd had no reason to install lsof as yet, having only fuser.

Next up the output of fuser was way more than the expected "just a pid": it included a bunch of permission denied entries while enumerating all non-user procs, and also some extra whitespace around the output pid, which was interacting poorly with the defensive quoting inside the sub-shell expansion of $tmp_pid.

TODO

  • maybe add river to the guess branch when using neither lsof nor fuser?

- permission denied spam from fuser was getting conflated into stdout
- unquote the inner $tmp_pid refereence, so that the shell will strip
  whitespace properly around the output pid number
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant