This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add a tiny sleep to fix image flashing and not drawing properly #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes it on gnome-terminal and termite. |
killmaster
approved these changes
Oct 3, 2016
|
paste to? @dylanaraps @killmaster |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the image not appearing when the thumbnail already exists, I'm not sure as to why this works but it seems to be related to timing between the thumbnail being created and w3m-img displaying it.
I've only tested this on my laptop and the only terminals I found to be affected were
Gnome-terminalandXfce4-terminal. Please test this out and let me know if it works or at least reduces the frequency of the bug.This isn't a very pretty fix but if it works it'll have to do until we can find a better way to solve this problem.
@killmaster
Closes #346