Skip to content

Commit

Permalink
Api separation (open-telemetry#727)
Browse files Browse the repository at this point in the history
* feat: create an api package

* chore: update circle for new api package

* chore: bring back getTracer

* chore: add wrongly removed dev dependency

* chore: review comments

* chore: review comments

* chore: lint

* chore: export all noop implementations

* chore: update API README

* chore: ignore known working links that are not yet published

* chore: add jsdoc for getInstance calls

* chore: add jsdoc for private constructors

* chore: review comments

* chore: fix readme npm url

* chore: fix old readmes without registry

* chore: update api calling convention
  • Loading branch information
dyladan authored Jan 29, 2020
1 parent 6056740 commit 3e2e0ff
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,6 @@
"webpack": "^4.35.2"
},
"dependencies": {
"@opentelemetry/types": "^0.3.3"
"@opentelemetry/api": "^0.3.3"
}
}
2 changes: 1 addition & 1 deletion src/JaegerHttpTraceFormat.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* limitations under the License.
*/

import { SpanContext, HttpTextFormat, TraceFlags } from '@opentelemetry/types';
import { SpanContext, HttpTextFormat, TraceFlags } from '@opentelemetry/api';

export const UBER_TRACE_ID_HEADER = 'uber-trace-id';

Expand Down
2 changes: 1 addition & 1 deletion test/JaegerHttpTraceFormat.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import {
JaegerHttpTraceFormat,
UBER_TRACE_ID_HEADER,
} from '../src/JaegerHttpTraceFormat';
import { SpanContext, TraceFlags } from '@opentelemetry/types';
import { SpanContext, TraceFlags } from '@opentelemetry/api';

describe('JaegerHttpTraceFormat', () => {
const jaegerHttpTraceFormat = new JaegerHttpTraceFormat();
Expand Down

0 comments on commit 3e2e0ff

Please sign in to comment.