Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[error] Support fmt.Formatter interface #62

Open
1 of 5 tasks
at15 opened this issue Mar 6, 2018 · 3 comments
Open
1 of 5 tasks

[error] Support fmt.Formatter interface #62

at15 opened this issue Mar 6, 2018 · 3 comments

Comments

@at15
Copy link
Member

at15 commented Mar 6, 2018

I am used to log.Warnf("err %v", err), but since we didn't implement formatter interface, the result is just struct ... it's quite a pain to call err.Error everytime

type Formatter interface {
        Format(f State, c rune)
}
@gaocegege
Copy link
Member

强无敌

at15 added a commit that referenced this issue Mar 6, 2018
- didn't support print stack ...
@at15 at15 changed the title [error] Suppor formmatter interface [error] Support fmt.Formatter interface Mar 6, 2018
at15 added a commit that referenced this issue Mar 6, 2018
[error] Implement fmt.Formatter #62 

- just print string
- [ ] stack is not handled
- [ ] format is passed down to wrapped and multi errors
@at15 at15 added this to the 0.0.8 milestone May 4, 2018
@at15 at15 modified the milestones: 0.0.9, 0.0.10 Dec 31, 2018
@at15 at15 modified the milestones: 0.0.10, 0.0.12 Apr 13, 2019
@at15
Copy link
Member Author

at15 commented Apr 13, 2019

the print interface seems also changed with new x/errors #109

@at15 at15 modified the milestones: 0.0.13, 0.0.14 Jan 18, 2020
@at15
Copy link
Member Author

at15 commented Jan 18, 2020

Although it is important ... won't hurt without its full implementation ... so moved it to 0.0.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants