Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[go] Switch from dep to vgo #74

Closed
at15 opened this issue Jun 13, 2018 · 1 comment
Closed

[go] Switch from dep to vgo #74

at15 opened this issue Jun 13, 2018 · 1 comment
Assignees
@at15
Labels
area/go type/refactor
Milestone
0.0.10

Comments

@at15
Copy link
Member

at15 commented Jun 13, 2018 •
edited
Loading

Although gommon didn't depend on many libraries, for projects using gommon to use vgo, gommon itself might need some change, haven't looked vgo in detail

Ref
@at15 at15 self-assigned this Jun 13, 2018
@at15 at15 mentioned this issue Jun 13, 2018
Closed
at15 added a commit that referenced this issue Dec 30, 2018
@at15
[go] Init go.mod #74 for using replace
23165f6 
- for using local version of gommon, users need to use the replace
directive and use a relative local path, this requires gommon to have a
go mod file, otherwise it won't work
- [ ] TODO: add ignore tag for legacy packages #105
at15 added a commit that referenced this issue Dec 30, 2018
@at15
[legacy] Ignore legacy pkgs using build tag #105
ebd4181 
- this also removed pkg/errors from go.mod #74
@at15 at15 added this to the 0.0.10 milestone Dec 31, 2018
at15 added a commit that referenced this issue Jan 8, 2019
@at15
[dep] Remove vendor and use go mod #74
34948b2
@at15
Copy link
Member Author

at15 commented Jan 8, 2019

fixed in #106

@at15 at15 closed this as completed Jan 8, 2019
at15 added a commit that referenced this issue Apr 8, 2019
@at15
[dep] Remove vendor and use go mod #74
e4d2b0a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@at15 at15

Labels
area/go type/refactor
Projects
None yet
Milestone
0.0.10
Development

No branches or pull requests
1 participant
@at15