Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add W25Q64JV QSPI /4 Boot2 file #929

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Add W25Q64JV QSPI /4 Boot2 file #929

merged 1 commit into from
Oct 20, 2022

Conversation

maxgerhardt
Copy link
Contributor

@maxgerhardt maxgerhardt commented Oct 18, 2022

A simple addition. Expands only the "Generic" variant by a "W25Q64JV QSPI /4" Boot2 option.

I was very tempted to also just add

# Pimoroni
MakeBoard("pimoroni_pga2040", "Pimoroni", "PGA2040", "0x2e8a", "0x1008", 250, "PIMORONI_PGA2040", 8, "boot2_w25q64jv_4_padded_checksum")

but the pimoroni_pga2040 would have just been a copy of the generic variant folder -- felt weird.

Resolves #927 more cleanly by giving them the possibility to use their flash chip on Quad-SPI mode (clock div 4) as intended and e.g. used by CircuitPython.

Copy link
Owner

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging into this new flash. I think I will do the makeboards addition you mentioned just to avoid having the same problem pop up again. Having a variant just for the flash type isn't unique to this board, IIRC, and the bits are free...

@earlephilhower earlephilhower merged commit b82336c into earlephilhower:master Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pimoroni PGA2040 wont accept Arduino-Core
2 participants