Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in .get_rd_h? #571

Closed
LukasWallrich opened this issue Mar 8, 2023 · 1 comment · Fixed by #572
Closed

Typo in .get_rd_h? #571

LukasWallrich opened this issue Mar 8, 2023 · 1 comment · Fixed by #572

Comments

@LukasWallrich
Copy link

Describe the bug
According to the documentation, when calculating d_to_r etc, one should be able to omit one group size (n1 or n2) if the groups are of equal size. However, .get_rd_h ignores the provided input if either (II) argument is missing.

if (missing(n1) || missing(n2)) {

Expected behavior
These two calls should return the same

library(effectsize)

d_to_r(.5, 10, 10)
#> [1] 0.2548236
d_to_r(.5, 10)
#> [1] 0.2425356

Created on 2023-03-08 with reprex v2.0.2

mattansb added a commit that referenced this issue Mar 8, 2023
@mattansb mattansb mentioned this issue Mar 8, 2023
@mattansb
Copy link
Member

mattansb commented Mar 8, 2023

Thanks for pointing this out! Fixed on #572

library(effectsize)
d_to_r(.5, 10, 10)
#> [1] 0.2548236
d_to_r(.5, 10)
#> [1] 0.2548236

Created on 2023-03-08 with reprex v2.0.2

@mattansb mattansb closed this as completed Mar 8, 2023
mattansb added a commit that referenced this issue Mar 9, 2023
* fix #571

* Update NEWS.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants