Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps #142

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Update deps #142

merged 2 commits into from
Jun 27, 2024

Conversation

matze
Copy link
Contributor

@matze matze commented Jun 16, 2024

Tests pass but I am not sure that the mapping from the new reader errors to UnexpectedEof are 100% identical.

@ebarnard
Copy link
Owner

Syntax looks to be pretty much equivalent to UnexpectedEof - https://docs.rs/quick-xml/latest/quick_xml/errors/enum.SyntaxError.html

IllFormed is a bit less clear, some variants do seem to be equivalent to UnexpectedEof, but some seem closer to other error types - https://docs.rs/quick-xml/latest/quick_xml/errors/enum.IllFormedError.html

The XML error types in plist's ErrorKind were built around xml-rs, so probably need a bit of a rethink.

I think it might be best to map Syntax to ErrorKind::UnexpectedEof and IllFormed to ErrorKind::InvalidXmlSyntax (confusingly) for the moment pending that rethink.

@matze
Copy link
Contributor Author

matze commented Jun 27, 2024

Changed, according to your suggestion. Let me know if you have a better idea later on.

@ebarnard ebarnard merged commit cb89f38 into ebarnard:master Jun 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants