DbMigration: Do only real type changes

ebean-orm · Mar 17, 2022 · 74720a8 · 74720a8
1 parent 923f83c
commit 74720a8
Showing 1 changed file with 13 additions and 1 deletion.
diff --git a/...rator/src/main/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/BaseTableDdl.java b/...rator/src/main/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/BaseTableDdl.java
@@ -723,7 +723,7 @@ public void generate(DdlWrite writer, AlterColumn alterColumn) {
  dropCheckConstraint(writer, alterColumn, alterColumn.getCheckConstraintName());
  }
 
- if (hasValue(alterColumn.getType())
+ if (typeChange(alterColumn)
  || hasValue(alterColumn.getDefaultValue())
  || alterColumn.isNotnull() != null) {
  alterColumn(writer, alterColumn);
@@ -735,6 +735,18 @@ public void generate(DdlWrite writer, AlterColumn alterColumn) {
  }
  }
 
+ private boolean typeChange(AlterColumn alterColumn) {
+ if (!hasValue(alterColumn.getType())) {
+ return false;
+ }
+ // check, if we have really a type change for that platform
+ // When specifying @Column("db2;clob(64K)") this would not alter
+ // other platforms from "String" to "String" for example
+ String currentType = platformDdl.convert(alterColumn.getCurrentType());
+ String type = platformDdl.convert(alterColumn.getType());
+ return !type.equals(currentType);
+ }
+
  private void alterColumnComment(DdlWrite writer, AlterColumn alterColumn) {
  platformDdl.addColumnComment(writer.applyPostAlter(), alterColumn.getTableName(), alterColumn.getColumnName(), alterColumn.getComment());
  }