Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LimitOffsetSqlLimiter applies 'LIMIT 0' if firstRow is set only. #2903

Closed
serg1236 opened this issue Nov 27, 2022 · 0 comments · Fixed by #2904
Closed

LimitOffsetSqlLimiter applies 'LIMIT 0' if firstRow is set only. #2903

serg1236 opened this issue Nov 27, 2022 · 0 comments · Fixed by #2904
Assignees
@serg1236
Labels
bug
Milestone
13.11.0

Comments

@serg1236
Copy link
Contributor

serg1236 commented Nov 27, 2022 •
edited
Loading

When Query::setFirstRow is used, it's expected to produce the OFFSET only. However, it produces LIMIT clause also.

Example:

  someQuery.setFirstRow(5);

Expected behavior

The generated query contains OFFSET 5 and no LIMIT at all

Actual behavior

The generated query contains LIMIT 0 OFFSET 5

I've created PR that fixes this issue: #2904
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@serg1236 serg1236

Labels
bug
Projects
None yet
Milestone
13.11.0
Development

Successfully merging a pull request may close this issue.

Fixed mandatory LIMIT generation in case of firstRow>0 serg1236/ebean
2 participants
@rbygrave @serg1236