DBName with hyphens creates invalid code

[Wattos]

Expected behavior

The generated code should be correct OR ebean should be explicit about not supporting Database names with hyphens

Actual behavior

The annotation processor fails with a compile exception as it generates incorrect code

Steps to reproduce

Create an entity and assign it to a database that has a hyphen in its name.

@DBName(name = "kebab-db-name") 
public class Entity {
}

Context:
We make use of ebean within the Quarkus framework and configure ebean with microprofile config.

We end up with configurations such as

quarkus.ebean.some-custom-database.enabled=true

At this point, we have to use underscores (which is not the end of the world), but is inconsistent with all of the other configuration parameters that use hyphens instead.

e.g.

%prod.mp.messaging.connector.smallrye-kafka.security.protocol=SASL_SSL

This seems to happen in the SimpleModuleInfoWriter.java (

ebean/querybean-generator/src/main/java/io/ebean/querybean/generator/SimpleModuleInfoWriter.java

Line 190 in a5d2a57

writeMethodComment("Entities for @DbName(name=\"%s\"))", dbName);

) where the database name is used directly in the method name.

A solution could be to simply remove any characters that cannot be used in method names in this function.

[Wattos]

Please note, this is just a minor issue as a workaround exists with using snake_case for the database name, but creates slightly less elegant code (as it creates inconsistencies in the Quarkus ecosystem)

[Wattos]

@rbygrave thank you for the quick fix of the issue. Very much appreciated!